Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: tests/dynamic_code_loading/nacl.scons

Issue 5738003: Resurrect Petr's 64-bit dynamic code modification CL:... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: added test for double-break condition Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/dynamic_code_loading/nacl.scons
===================================================================
--- tests/dynamic_code_loading/nacl.scons (revision 3931)
+++ tests/dynamic_code_loading/nacl.scons (working copy)
@@ -38,10 +38,10 @@
template_obj],
EXTRA_LIBS=['testrunner', 'srpc', 'pthread'])
-# Uncomment once the toolchain gets the new syscalls:
-#env.ComponentProgram('dynamic_modify_test.nexe',
-# ['dynamic_modify_test.c',
-# template_obj])
+env.ComponentProgram('dynamic_modify_test.nexe',
+ ['dynamic_modify_test.c',
+ template_obj],
+ EXTRA_LIBS=['testrunner', 'srpc', 'pthread'])
env.ComponentProgram('write_to_dyncode.nexe',
['write_to_dyncode.c'])
@@ -80,16 +80,16 @@
sel_ldr_flags=["-c"],
command=[env.File('debug_mode_test.nexe')],
),
-# Uncomment once the toolchain gets the new syscalls:
-# env.CommandSelLdrTestNacl(
-# 'dynamic_modify_test_disabled.out',
-# command=[env.File('dynamic_modify_test.nexe')],
-# ),
-# env.CommandSelLdrTestNacl(
-# 'dynamic_modify_test_enabled.out',
-# command=[env.File('dynamic_modify_test.nexe')],
-# osenv='NACL_ALLOW_DYNCODE_REPLACEMENT=1',
-# ),
+ env.CommandSelLdrTestNacl(
+ 'dynamic_modify_test_disabled.out',
+ command=[env.File('dynamic_modify_test.nexe')],
+ osenv='NACL_SRPC_STANDALONE=1',
+ ),
+ env.CommandSelLdrTestNacl(
+ 'dynamic_modify_test_enabled.out',
+ command=[env.File('dynamic_modify_test.nexe')],
+ osenv='NACL_ALLOW_DYNCODE_REPLACEMENT=1,NACL_SRPC_STANDALONE=1',
+ ),
]
# TODO(kcc): non-standard linking options confuse Valgrind debug info reader.

Powered by Google App Engine
This is Rietveld 408576698