Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 5737005: emacs: use curl to fetch trybot output, improve mac performance (Closed)

Created:
10 years ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

emacs: use curl to fetch trybot output, improve mac performance By using a command to fetch trybot output, we can pipe the result through a sed script that trims down the Mac output. This makes the output small enough so that compilation-mode can handle it. While I'm at it, I can use file:/// URLs to unify more of the "real" and "test" code paths. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69069

Patch Set 1 #

Patch Set 2 : ok #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1877 lines, -209 lines) Patch
M tools/emacs/trybot.el View 1 2 chunks +39 lines, -17 lines 0 comments Download
M tools/emacs/trybot-mac.txt View 1 chunk +1838 lines, -192 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
10 years ago (2010-12-13 22:50:17 UTC) #1
Scott Byer
10 years ago (2010-12-13 23:32:50 UTC) #2
LGTM

On 2010/12/13 22:50:17, Evan Martin wrote:

Powered by Google App Engine
This is Rietveld 408576698