Issue 5736004: Added 'dry run' tag to the print job, to test proxy health without wasting pa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5736004: Added 'dry run' tag to the print job, to test proxy health without wasting pa... (Closed)

Created:
10 years ago by gene

Modified:
9 years, 5 months ago

Reviewers:
sanjeevr

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added 'dry run' tag to the print job, to test proxy health without wasting paper/ink. BUG=none TEST=Make sure 'dry run' jobs does not get printed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69071

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -9 lines)			Patch
M	chrome/service/cloud_print/cloud_print_consts.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_consts.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.cc	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/print_system.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View	1 2 3 4	7 chunks	+43 lines, -6 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.h	View	1 2 3 4	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.cc	View	1 2 3 4	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sanjeevr

10 years ago (2010-12-10 23:50:02 UTC) #2

LGTM with a couple of nits.

http://codereview.chromium.org/5736004/diff/25001/chrome/service/cloud_print/...
File chrome/service/cloud_print/print_system_cups.cc (right):

http://codereview.chromium.org/5736004/diff/25001/chrome/service/cloud_print/...
chrome/service/cloud_print/print_system_cups.cc:338: if (dry_run) {
if (dry_run || job_id) ?

http://codereview.chromium.org/5736004/diff/25001/chrome/service/cloud_print/...
chrome/service/cloud_print/print_system_cups.cc:670:
std::vector<std::string>::const_iterator tags_it;
Can you move this loop to CLoudPrintHelpers so we can use this in Windows code
as well?

Expand Messages | Collapse Messages