Continuation of CL 5685007, rename the singleton accessor method in more files.

Rename all methods accessing Singleton<T> as GetInstance().
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.

This primarily covers files in chrome os and other directories, missed in the previous CL.

In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase.

BUG=65298
TEST=all existing tests should pass.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69007

[M-A Ruel, 2010-12-13 15:54:02]

Only nits, lgtm.

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/gvie...
File chrome/browser/chromeos/gview_request_interceptor.h (right):

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/gvie...
chrome/browser/chromeos/gview_request_interceptor.h:35: static
GViewRequestInterceptor* GetInstance();
I think you should keep returning the interface.

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/usb_...
File chrome/browser/chromeos/usb_mount_observer_browsertest.cc (right):

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/usb_...
chrome/browser/chromeos/usb_mount_observer_browsertest.cc:45:
chromeos::USBMountObserver* observe = chromeos::USBMountObserver::GetInstance();
80 cols

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/wm_i...
File chrome/browser/chromeos/wm_ipc.cc (right):

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/wm_i...
chrome/browser/chromeos/wm_ipc.cc:66: return g_wm_ipc.Pointer();
Eh, thanks for fixing it.

[Satish, 2010-12-13 15:57:49]

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/gvie...
File chrome/browser/chromeos/gview_request_interceptor.h (right):

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/gvie...
chrome/browser/chromeos/gview_request_interceptor.h:35: static
GViewRequestInterceptor* GetInstance();
On 2010/12/13 15:54:02, Marc-Antoine Ruel wrote:
> I think you should keep returning the interface.

This change is required because soon Singleton<T> will have all methods as
private and only allow access to a "friend Type* Type::GetInstance()" method in
the singleton class. I can't see a way to a allow access for custom function
prototypes, hence these changes to make all of them conform to the "Type*
GetInstance()" signature.

[M-A Ruel, 2010-12-13 16:16:37]

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/gvie...
File chrome/browser/chromeos/gview_request_interceptor.h (right):

http://codereview.chromium.org/5734002/diff/2001/chrome/browser/chromeos/gvie...
chrome/browser/chromeos/gview_request_interceptor.h:35: static
GViewRequestInterceptor* GetInstance();
On 2010/12/13 15:57:49, Satish wrote:
> On 2010/12/13 15:54:02, Marc-Antoine Ruel wrote:
> > I think you should keep returning the interface.
> 
> This change is required because soon Singleton<T> will have all methods as
> private and only allow access to a "friend Type* Type::GetInstance()" method
in
> the singleton class. I can't see a way to a allow access for custom function
> prototypes, hence these changes to make all of them conform to the "Type*
> GetInstance()" signature.

No problem then.

lgtm