Issue 5733004: Attempt to fix compare performance regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5733004: Attempt to fix compare performance regression.

Created:
10 years ago by Vitaly Repeshko

Modified:
10 years ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Attempt to fix compare performance regression.

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -6 lines)			Patch
M	src/ia32/ic-ia32.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	src/ic.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic.cc	View	1 chunk	+7 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years ago (2010-12-11 15:18:46 UTC) #2

LGTM!

http://codereview.chromium.org/5733004/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/5733004/diff/1/src/ic.cc#newcode2142
src/ic.cc:2142: x->IsNumber() && y->IsNumber()) return HEAP_NUMBERS;
Would the condition 
(state == UNINITIALIZED || state == SMIS) &&
x->IsNumber() &&
y->IsNumber())

be sufficient here? So that we always go from SMI to HEAP_NUMBER before going to
GENERIC.

Expand Messages | Collapse Messages