Issue 5733003: Use SChannel for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5733003: Use SChannel for Windows. (Closed)

Created:
10 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use SChannel for Windows. Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68827

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address wtc comments. #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/browser_main_win.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/5733003/diff/1/chrome/browser/browser_main_win.cc File chrome/browser/browser_main_win.cc (right): http://codereview.chromium.org/5733003/diff/1/chrome/browser/browser_main_win.cc#newcode243 chrome/browser/browser_main_win.cc:243: // if (!parsed_command_line().HasSwitch(switches::kUseSystemSSL)) { Please add a comment ...

10 years ago (2010-12-10 01:29:13 UTC) #2

willchan no longer on Chromium

10 years ago (2010-12-10 01:49:48 UTC) #3

Ok, I've addressed the comments.  Assuming win trybot still looks good, I'll
land this tonight and hopefully it'll make the canary release so I can revert
tomorrow.

Expand Messages | Collapse Messages