Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 5733001: Introduce additional context to evaluate operations (Closed)

Created:
10 years ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce additional context to evaluate operations Committed: http://code.google.com/p/v8/source/detail?r=5997

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : presubmit #

Patch Set 4 : clean #

Patch Set 5 : merge #

Total comments: 8

Patch Set 6 : follow codereview #

Patch Set 7 : merge #

Patch Set 8 : small format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -14 lines) Patch
M src/debug-debugger.js View 1 2 3 4 5 6 7 5 chunks +26 lines, -7 lines 0 comments Download
M src/mirror-debugger.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 5 6 6 chunks +23 lines, -3 lines 0 comments Download
A test/mjsunit/debug-evaluate-with-context.js View 1 2 3 4 5 6 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Rybin
Hi Soren I'd like to extend evaluate semantics in remote debug protocol. This fix allows ...
10 years ago (2010-12-09 22:36:35 UTC) #1
Søren Thygesen Gjesse
LGTM, with some additional test where the protocol message with additional context is tested. http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js ...
10 years ago (2010-12-13 08:37:14 UTC) #2
Peter Rybin
http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js#newcode879 src/debug-debugger.js:879: ExecutionState.prototype.evaluateGlobal = function(source, disable_break, opt_additional_context) { On 2010/12/13 08:37:14, ...
10 years ago (2010-12-14 00:02:52 UTC) #3
Søren Thygesen Gjesse
10 years ago (2010-12-15 12:04:03 UTC) #4
LGTM with the changed representation of the additional_context discused in mail
thread.

Powered by Google App Engine
This is Rietveld 408576698