Introduce additional context to evaluate operations

Introduce additional context to evaluate operations

Committed: http://code.google.com/p/v8/source/detail?r=5997

[Peter Rybin, 2010-12-09 22:36:35]

Hi Soren

I'd like to extend evaluate semantics in remote debug protocol. This fix allows
remote client to use handles in evaluate commands.

I'm planning to implement such features as "calculate toString", "pin-point this
reference to a global object" etc on top of this feature.

Peter

[Søren Thygesen Gjesse, 2010-12-13 08:37:14]

LGTM, with some additional test where the protocol message with additional
context is tested.

http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js
File src/debug-debugger.js (right):

http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js#newco...
src/debug-debugger.js:879: ExecutionState.prototype.evaluateGlobal =
function(source, disable_break, opt_additional_context) {
Long line - more below.

http://codereview.chromium.org/5733001/diff/10001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/5733001/diff/10001/src/runtime.cc#newcode9835
src/runtime.cc:9835: if (additional_context->IsJSObject()) {
4 char indent.

http://codereview.chromium.org/5733001/diff/10001/src/runtime.cc#newcode9840
src/runtime.cc:9840: context =
Factory::NewFunctionContext(Context::MIN_CONTEXT_SLOTS,
I suggest splitting this line either after the '=' or the '(' if possible.
Keeping the function arguments together if possible.

http://codereview.chromium.org/5733001/diff/10001/test/mjsunit/debug-evaluate...
File test/mjsunit/debug-evaluate-with-context.js (right):

http://codereview.chromium.org/5733001/diff/10001/test/mjsunit/debug-evaluate...
test/mjsunit/debug-evaluate-with-context.js:43: var result =
exec_state.frame(0).evaluate(local_expression, void 0, context).value();
Please cases where no additional context is passed as well.

[Peter Rybin, 2010-12-14 00:02:52]

http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js
File src/debug-debugger.js (right):

http://codereview.chromium.org/5733001/diff/10001/src/debug-debugger.js#newco...
src/debug-debugger.js:879: ExecutionState.prototype.evaluateGlobal =
function(source, disable_break, opt_additional_context) {
On 2010/12/13 08:37:14, Søren Gjesse wrote:
> Long line - more below.

Done.

http://codereview.chromium.org/5733001/diff/10001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/5733001/diff/10001/src/runtime.cc#newcode9835
src/runtime.cc:9835: if (additional_context->IsJSObject()) {
On 2010/12/13 08:37:14, Søren Gjesse wrote:
> 4 char indent.

Done.

http://codereview.chromium.org/5733001/diff/10001/src/runtime.cc#newcode9840
src/runtime.cc:9840: context =
Factory::NewFunctionContext(Context::MIN_CONTEXT_SLOTS,
On 2010/12/13 08:37:14, Søren Gjesse wrote:
> I suggest splitting this line either after the '=' or the '(' if possible.
> Keeping the function arguments together if possible.

Done.

http://codereview.chromium.org/5733001/diff/10001/test/mjsunit/debug-evaluate...
File test/mjsunit/debug-evaluate-with-context.js (right):

http://codereview.chromium.org/5733001/diff/10001/test/mjsunit/debug-evaluate...
test/mjsunit/debug-evaluate-with-context.js:43: var result =
exec_state.frame(0).evaluate(local_expression, void 0, context).value();
On 2010/12/13 08:37:14, Søren Gjesse wrote:
> Please cases where no additional context is passed as well.

Done.

[Søren Thygesen Gjesse, 2010-12-15 12:04:03]

LGTM with the changed representation of the additional_context discused in mail
thread.