Issue 573041: Add the ssl_client_socket_nss_factory.h header and declare...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 573041: Add the ssl_client_socket_nss_factory.h header and declare... (Closed)

Created:
10 years, 10 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, darin (slow to review), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add the ssl_client_socket_nss_factory.h header and declare the SSLClientSocketNSSFactory function there. Put the --use-nss-for-ssl command-line switch inside ifdefs for the platforms that need it. Call EnsureNSPRInit on the main thread so that PR_Cleanup will be called on the main thread. R=mark BUG=28744 TEST=No build errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38515

Patch Set 1 #

Patch Set 2 : Sync with the current trunk. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -60 lines)			Patch
M	chrome/browser/browser_main.cc	View	1	5 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	net/net.gyp	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/socket/client_socket_factory.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/socket/client_socket_factory.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A +	net/socket/ssl_client_socket_nss_factory.h	View		1 chunk	+5 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 10 months ago (2010-02-09 04:06:01 UTC) #2

LGTM.  I'm sorry for the delay, I guess I managed to skip some things that came
in during what would be considered the weekend in my timezone.

Expand Messages | Collapse Messages