Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 5730004: Rename ExtensionsService to ExtensionService. (Closed)

Created:
10 years ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman, dhollowa
CC:
chromium-reviews, ceee-reviews_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Rename ExtensionsService to ExtensionService. BUG=61409 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69117

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebased and renamed/moved unittest as well. #

Patch Set 6 : fix rebase conflict #

Patch Set 7 : minor fixes #

Patch Set 8 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+832 lines, -832 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_extension_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/background_application_list_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background_application_list_model.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/background_contents_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background_mode_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background_page_tracker.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data_remover.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/app_launcher_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/app_launcher_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/all_urls_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/content_script_extension_process_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crashed_extension_infobar.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/crashed_extension_infobar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 4 13 chunks +39 lines, -39 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_dom_ui.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_idle_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_management_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_browsertest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_module.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_api.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_proxy_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/extensions/extension_service.h View 12 chunks +19 lines, -19 lines 0 comments Download
A + chrome/browser/extensions/extension_service.cc View 1 2 3 4 67 chunks +127 lines, -127 lines 0 comments Download
A + chrome/browser/extensions/extension_service_unittest.h View 1 2 3 4 4 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 84 chunks +154 lines, -154 lines 0 comments Download
M chrome/browser/extensions/extension_sidebar_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_test_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extensions_startup.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/page_action_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification_options_menu_model.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugin_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/site_instance.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_change_processor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/extension_sync.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/extension_sync.cc View 11 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/sync/glue/extension_sync_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/theme_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/themes/browser_theme_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/message_box_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/preferences_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/notification_type.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/live_extensions_sync_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/live_sync/live_extensions_sync_test_base.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/live_themes_sync_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/testing_profile.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M tools/valgrind/wine_memcheck/suppressions.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/wine_valgrind/chromium-valgrind-suppressions View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Please, take a look.
10 years ago (2010-12-13 23:48:36 UTC) #1
Aaron Boodman
Freaking awesome. Can you fix extensions_service_unittest too?
10 years ago (2010-12-14 01:34:17 UTC) #2
tfarina
On 2010/12/14 01:34:17, Aaron Boodman wrote: > Freaking awesome. Can you fix extensions_service_unittest too? Sure, ...
10 years ago (2010-12-14 02:04:43 UTC) #3
tfarina
Please, take another look.
10 years ago (2010-12-14 03:00:16 UTC) #4
Aaron Boodman
LGTM Thanks for doing this!
10 years ago (2010-12-14 05:26:37 UTC) #5
dhollowa
On 2010/12/14 05:26:37, Aaron Boodman wrote: > LGTM > > Thanks for doing this! Small ...
10 years ago (2010-12-14 17:22:52 UTC) #6
tfarina
On 2010/12/14 17:22:52, dhollowa wrote: > On 2010/12/14 05:26:37, Aaron Boodman wrote: > > LGTM ...
10 years ago (2010-12-14 17:37:44 UTC) #7
dhollowa
10 years ago (2010-12-14 17:41:24 UTC) #8
On 2010/12/14 17:37:44, tfarina wrote:
> On 2010/12/14 17:22:52, dhollowa wrote:
> > On 2010/12/14 05:26:37, Aaron Boodman wrote:
> > > LGTM
> > > 
> > > Thanks for doing this!
> > 
> > Small addition at:
> > 
> >   http://codereview.chromium.org/5730004/
> 
> This url points to this issue. Wrong url? But I think this is not the right
> place to discuss this. Send an email instead?

Woops, yes.  Correct URL is:

  http://codereview.chromium.org/5761002/

Powered by Google App Engine
This is Rietveld 408576698