Issue 5730002: Disable crashy IndexedDBBrowserTest.DoesntHangTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5730002: Disable crashy IndexedDBBrowserTest.DoesntHangTest (Closed)

Created:
10 years ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Disable crashy IndexedDBBrowserTest.DoesntHangTest TBR=jorlow BUG=66394 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68862

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/in_process_webkit/indexed_db_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jorlow

10 years ago (2010-12-10 17:57:32 UTC) #2

LGTM

On Fri, Dec 10, 2010 at 5:53 PM, <phajdan.jr@chromium.org> wrote:

> Reviewers: jorlow,
>
> Message:
> TBR
>
> Description:
> Disable crashy IndexedDBBrowserTest.DoesntHangTest
>
> TBR=jorlow
>
> BUG=66394
> TEST=browser_tests
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68862
>
> Please review this at http://codereview.chromium.org/5730002/
>
> Affected files:
>  M chrome/browser/in_process_webkit/indexed_db_browsertest.cc
>
>
> Index: chrome/browser/in_process_webkit/indexed_db_browsertest.cc
> diff --git a/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
> b/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
> index
>
d66c820a2057f8c0039644fe80e2f0d00c48d823..0666244f5a4481d76c193e145cdac86d7f908b63
> 100644
> --- a/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
> +++ b/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
> @@ -78,7 +78,8 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest,
> TransactionTest) {
>
> SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("transaction_test.html"))));
>  }
>
> -IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DoesntHangTest) {
> +// Crashy, http://crbug.com/66394.
> +IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_DoesntHangTest) {
>   SimpleTest(testUrl(FilePath(
>       FILE_PATH_LITERAL("transaction_run_forever.html"))));
>   ui_test_utils::CrashTab(browser()->GetSelectedTabContents());
>
>
>

Expand Messages | Collapse Messages