Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 5730001: Merge 68411 - Make chrome.omnibox.setDefaultSuggestion work when called insid... (Closed)

Created:
10 years ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 68411 - Make chrome.omnibox.setDefaultSuggestion work when called inside onInputChanged. BUG=64538 TEST=Use the chrome_search sample extension and make sure the first suggestion updates in sync with what you type. Review URL: http://codereview.chromium.org/5607003 TBR=mpcomplete@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -43 lines) Patch
M chrome/browser/autocomplete/keyword_provider.cc View 2 chunks +68 lines, -43 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Matt Perry
10 years ago (2010-12-09 18:47:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698