Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 5729004: Merge the installer, installer_util and setup_util namespaces into a single i... (Closed)

Created:
10 years ago by robertshield
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., jshin+watch_chromium.org, ceee-reviews_chromium.org
Visibility:
Public.

Description

Merge the installer, installer_util and setup_util namespaces into a single installer namespace. BUG=61609 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69165

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -550 lines) Patch
M ceee/common/install_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ceee/installer_dll/installer_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/client_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_main_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 12 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/setup/install.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 20 chunks +51 lines, -51 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 33 chunks +104 lines, -104 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/setup/uninstall.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 18 chunks +37 lines, -37 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 8 chunks +17 lines, -17 lines 0 comments Download
M chrome/installer/util/browser_distribution_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/channel_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/channel_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/channel_info_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 12 chunks +23 lines, -23 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/google_update_settings.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/util/l10n_string_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/language_selector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/language_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/language_selector_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/logging_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/logging_installer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/master_preferences.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 6 chunks +37 lines, -37 lines 2 comments Download
M chrome/installer/util/master_preferences_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_dummy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 12 chunks +64 lines, -64 lines 0 comments Download
M chrome/installer/util/package.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/package_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/product.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/product.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/util_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/test.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertshield
10 years ago (2010-12-13 19:43:28 UTC) #1
tommi (sloooow) - chröme
lgtm. One general comment below. I'm fine with addressing that organically. http://codereview.chromium.org/5729004/diff/1/chrome/installer/util/master_preferences.cc File chrome/installer/util/master_preferences.cc (left): ...
10 years ago (2010-12-13 20:28:06 UTC) #2
robertshield
10 years ago (2010-12-13 21:43:53 UTC) #3
Thanks!

http://codereview.chromium.org/5729004/diff/1/chrome/installer/util/master_pr...
File chrome/installer/util/master_preferences.cc (left):

http://codereview.chromium.org/5729004/diff/1/chrome/installer/util/master_pr...
chrome/installer/util/master_preferences.cc:117: if
(cmd_line.HasSwitch(installer_util::switches::kInstallerData)) {
On 2010/12/13 20:28:06, tommi wrote:
> nit: I guess there are several places where this is now true, but the
> installer:: prefix isn't necessary anymore since this code is already in the
> installer namespace.

Yes, I'd rather keep this a search and replace type CL. I can clean up the
redundant namespaces in a new CL.

Powered by Google App Engine
This is Rietveld 408576698