Issue 5729001: Mac: Align tabpose titles on pixel boundaries, making them less blurry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5729001: Mac: Align tabpose titles on pixel boundaries, making them less blurry. (Closed)

Created:
10 years ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Align tabpose titles on pixel boundaries, making them less blurry. Also align favicon and title at their vertical center instead of at the baseline to match the tab look. BUG=50307 TEST=Open tabpose. Titles shouldn't be blurry. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68753

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	chrome/browser/ui/cocoa/tabpose_window.mm	View		3 chunks	+14 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

10 years ago (2010-12-09 18:40:52 UTC) #2

LGTMWN.

http://codereview.chromium.org/5729001/diff/1/chrome/browser/ui/cocoa/tabpose...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/5729001/diff/1/chrome/browser/ui/cocoa/tabpose...
chrome/browser/ui/cocoa/tabpose_window.mm:434: // Changes |title_rect| and
|favicon_rect| such that the favicon's and the
"the favicon and title's vertical centers are aligned"

Expand Messages | Collapse Messages