Issue 5728005: Remove layer of indirection in PhoneNumberTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5728005: Remove layer of indirection in PhoneNumberTest (Closed)

Created:
10 years ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Ilya Sherman, Paweł Hajdan Jr., James Hawkins, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove layer of indirection in PhoneNumberTest BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69045

Patch Set 1 #

Total comments: 1

Patch Set 2 : A friend to all prefixes #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -36 lines)			Patch
	M	chrome/browser/autofill/phone_number.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/autofill/phone_number_unittest.cc	View		2 chunks	+9 lines, -34 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dhollowa

10 years ago (2010-12-12 06:55:32 UTC) #2

LGTM.  One small nit.

http://codereview.chromium.org/5728005/diff/1/chrome/browser/autofill/phone_n...
File chrome/browser/autofill/phone_number.h (right):

http://codereview.chromium.org/5728005/diff/1/chrome/browser/autofill/phone_n...
chrome/browser/autofill/phone_number.h:52: FRIEND_TEST(PhoneNumberTest,
Matcher);
FRIEND_TEST_ALL_PREFIXES

Expand Messages | Collapse Messages