Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 5727003: Explicitly ignore return value of sk_SSL_COMP_delete. (Closed)

Created:
10 years ago by hans
Modified:
9 years, 5 months ago
Reviewers:
Mike Belshe, mbelshe, Nico
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Explicitly ignore return value of sk_SSL_COMP_delete. Explicitly cast the returned value into the void. Clang complains about this unused return value otherwise. BUG=none TEST=flip_in_mem_edsm_server Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/tools/flip_server/flip_in_mem_edsm_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
hans
10 years ago (2010-12-13 12:06:51 UTC) #1
mbelshe
10 years ago (2010-12-13 16:41:21 UTC) #2
lgtm

what is clang?

On Mon, Dec 13, 2010 at 4:06 AM, <hans@chromium.org> wrote:

> Reviewers: Mike Belshe, Nico,
>
> Description:
> Explicitly ignore return value of sk_SSL_COMP_delete.
>
> Explicitly cast the returned value into the void. Clang complains
> about this unused return value otherwise.
>
> BUG=none
> TEST=flip_in_mem_edsm_server
>
> Please review this at http://codereview.chromium.org/5727003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M net/tools/flip_server/flip_in_mem_edsm_server.cc
>
>
> Index: net/tools/flip_server/flip_in_mem_edsm_server.cc
> diff --git a/net/tools/flip_server/flip_in_mem_edsm_server.cc
> b/net/tools/flip_server/flip_in_mem_edsm_server.cc
> index
>
c19d52e56416753b0669d86f5d08a59b7ffaa61e..4faa6d4b2aa9488b9b3f4b16f53b84bd35e16d57
> 100644
> --- a/net/tools/flip_server/flip_in_mem_edsm_server.cc
> +++ b/net/tools/flip_server/flip_in_mem_edsm_server.cc
> @@ -253,7 +253,7 @@ void spdy_init_ssl(SSLState* state,
>     int num_methods = sk_SSL_COMP_num(ssl_comp_methods);
>     int i;
>     for (i = 0; i < num_methods; i++) {
> -      sk_SSL_COMP_delete(ssl_comp_methods, i);
> +      static_cast<void>(sk_SSL_COMP_delete(ssl_comp_methods, i));
>     }
>   }
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698