Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 5727002: IndexedDB: Preparatory patch for https://bugs.webkit.org/show_bug.cgi?id=50674 (Closed)

Created:
10 years ago by hans
Modified:
9 years, 5 months ago
Reviewers:
jorlow
CC:
chromium-reviews
Visibility:
Public.

Description

IndexedDB: Preparatory patch for https://bugs.webkit.org/show_bug.cgi?id=50674 WebIDBKey::number() will be changed to return a double. Cast this to int explicitly to avoid warnings in the mean time (esp. on Visual Studio). BUG=65619 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/indexed_db_key.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
hans
10 years ago (2010-12-10 09:34:39 UTC) #1
jorlow
10 years ago (2010-12-10 10:00:58 UTC) #2
LGTM

On Fri, Dec 10, 2010 at 9:34 AM, <hans@chromium.org> wrote:

> Reviewers: jorlow,
>
> Description:
> IndexedDB: Preparatory patch for
> https://bugs.webkit.org/show_bug.cgi?id=50674
>
> WebIDBKey::number() will be changed to return a double.
> Cast this to int explicitly to avoid warnings in the mean time (esp. on
> Visual
> Studio).
>
> BUG=65619
> TEST=none
>
> Please review this at http://codereview.chromium.org/5727002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/common/indexed_db_key.cc
>
>
> Index: chrome/common/indexed_db_key.cc
> diff --git a/chrome/common/indexed_db_key.cc
> b/chrome/common/indexed_db_key.cc
> index
>
9f7d1537e858af54dae53d9d43d6d347d7ce2f76..b4b0de4b8bc607edcd8b3d29f0d56031a274372c
> 100644
> --- a/chrome/common/indexed_db_key.cc
> +++ b/chrome/common/indexed_db_key.cc
> @@ -43,7 +43,8 @@ void IndexedDBKey::Set(const WebIDBKey& key) {
>   type_ = key.type();
>   string_ = key.type() == WebIDBKey::StringType ?
>                 static_cast<string16>(key.string()) : string16();
> -  number_ = key.type() == WebIDBKey::NumberType ? key.number() : 0;
> +  number_ = key.type() == WebIDBKey::NumberType ?
> +      static_cast<int32_t>(key.number()) : 0;
>  }
>
>  IndexedDBKey::operator WebIDBKey() const {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698