Issue 5726008: Reapply change 5989, adding untagged double calls to Math.pow, with problem i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5726008: Reapply change 5989, adding untagged double calls to Math.pow, with problem i... (Closed)

Created:
10 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reapply change 5989, adding untagged double calls to Math.pow, with problem in generated code for TranscendentalCacheSSE2Stub (unguarded SSE 4.1 code) fixed. Committed: http://code.google.com/p/v8/source/detail?r=6010

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+307 lines, -52 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	4 chunks	+39 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+137 lines, -0 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	5 chunks	+64 lines, -32 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+22 lines, -16 lines	0 comments	Download
M	src/math.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years ago (2010-12-14 13:19:05 UTC) #1

Only change to changelist 5989 is in code-stubs-ia32.cc:2700-2800, adding SSE4.1
guard and alternative for pextrd instruction, and using kDoubleSize rather than
2 * kPointerSize.

Expand Messages | Collapse Messages