Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 5726007: Autofill suggested dropdown list should be closed with unmatched names (Closed)

Created:
10 years ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Autofill suggested dropdown list should be closed with unmatched names This change adds an explicit call to |hidePopups| when no username/password completion matches the contents of the username text field. BUG=65985 TEST=Manual, according to bug steps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/renderer/password_autocomplete_manager.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dhollowa
10 years ago (2010-12-13 18:50:53 UTC) #1
Jay Civelli
10 years ago (2010-12-13 18:55:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698