Issue 5724001: Fix typo where host prebuilts aren't getting updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5724001: Fix typo where host prebuilts aren't getting updated. (Closed)

Created:
10 years ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
scottz, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Fix typo where host prebuilts aren't getting updated. archive_build.sh has code to archive host prebuilts, but the code isn't working because of a typo in archive_build.sh. The typo: $FLAGS_board is misspelled as $FLAGS_BOARD. BUG=chromium-os:10148 TEST=Ran prebuilt.py with --sync-host option Change-Id: I50129b1fdfb931b1c076a064b970d7d943f556ac Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3146eaa

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	archive_build.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

davidjames

What are your thoughts on this? This is actually a major change even though it's ...

10 years ago (2010-12-09 17:26:56 UTC) #1

anush

10 years ago (2010-12-09 19:33:17 UTC) #3

LGTM though it is committed :)


On Thu, Dec 9, 2010 at 9:28 AM,  <scottz@chromium.org> wrote:
> Good catch, lets do it.
>
> LGTM
>
> http://codereview.chromium.org/5724001/
>

Expand Messages | Collapse Messages