Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 5722004: Be less verbose while changing the password. Add a script for checking if password already exists. (Closed)

Created:
10 years ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
scottz
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Be less verbose while changing the password. Add a script for checking if password already exists. Change-Id: Ia2b524e0bb2935d7acf220e78aebc65255cd26a2 BUG=chrome-os-partner:1564 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=04d9975

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
A scripts/image_signing/ensure_no_password.sh View 1 1 chunk +25 lines, -0 lines 0 comments Download
M scripts/image_signing/set_chronos_password.sh View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gauravsh
10 years ago (2010-12-10 21:36:03 UTC) #1
scottz
http://codereview.chromium.org/5722004/diff/1/scripts/image_signing/ensure_no_password.sh File scripts/image_signing/ensure_no_password.sh (right): http://codereview.chromium.org/5722004/diff/1/scripts/image_signing/ensure_no_password.sh#newcode11 scripts/image_signing/ensure_no_password.sh:11: set -e We probably want this about the sourcing ...
10 years ago (2010-12-10 22:23:23 UTC) #2
gauravsh
On Fri, Dec 10, 2010 at 2:23 PM, <scottz@chromium.org> wrote: > > http://codereview.chromium.org/5722004/diff/1/scripts/image_signing/ensure_no_password.sh > File ...
10 years ago (2010-12-10 22:25:47 UTC) #3
scottz
10 years ago (2010-12-10 22:36:07 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698