Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3792)

Unified Diff: chrome/browser/renderer_host/resource_message_filter.cc

Issue 5722003: Make DOMStorageDispatcherHost be a message filter (and rename it accordingly)... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_message_filter.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter.cc (revision 68741)
+++ chrome/browser/renderer_host/resource_message_filter.cc (working copy)
@@ -27,7 +27,6 @@
#include "chrome/browser/geolocation/geolocation_permission_context.h"
#include "chrome/browser/gpu_process_host.h"
#include "chrome/browser/host_zoom_map.h"
-#include "chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h"
#include "chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h"
#include "chrome/browser/metrics/histogram_synchronizer.h"
#include "chrome/browser/mime_registry_dispatcher.h"
@@ -255,8 +254,6 @@
media_request_context_(profile->GetRequestContextForMedia()),
extensions_request_context_(profile->GetRequestContextForExtensions()),
render_widget_helper_(render_widget_helper),
- ALLOW_THIS_IN_INITIALIZER_LIST(dom_storage_dispatcher_host_(
- new DOMStorageDispatcherHost(this, profile->GetWebKitContext()))),
ALLOW_THIS_IN_INITIALIZER_LIST(indexed_db_dispatcher_host_(
new IndexedDBDispatcherHost(this, profile))),
ALLOW_THIS_IN_INITIALIZER_LIST(db_dispatcher_host_(
@@ -287,11 +284,11 @@
ALLOW_THIS_IN_INITIALIZER_LIST(file_utilities_dispatcher_host_(
new FileUtilitiesDispatcherHost(this, this->id()))),
ALLOW_THIS_IN_INITIALIZER_LIST(mime_registry_dispatcher_(
- new MimeRegistryDispatcher(this))) {
+ new MimeRegistryDispatcher(this))),
+ webkit_context_(profile->GetWebKitContext()) {
request_context_ = profile_->GetRequestContext();
DCHECK(request_context_);
DCHECK(media_request_context_);
- DCHECK(dom_storage_dispatcher_host_.get());
render_widget_helper_->Init(id(), resource_dispatcher_host_);
#if defined(OS_CHROMEOS)
@@ -306,9 +303,6 @@
// This function should be called on the IO thread.
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- // Tell the DOM Storage dispatcher host to stop sending messages via us.
- dom_storage_dispatcher_host_->Shutdown();
-
// Tell the Indexed DB dispatcher host to stop sending messages via us.
indexed_db_dispatcher_host_->Shutdown();
@@ -354,7 +348,6 @@
set_handle(peer_handle);
WorkerService::GetInstance()->Initialize(resource_dispatcher_host_);
- dom_storage_dispatcher_host_->Init(id(), handle());
indexed_db_dispatcher_host_->Init(id(), handle());
db_dispatcher_host_->Init(handle());
file_system_dispatcher_host_->Init(handle());
@@ -383,7 +376,6 @@
bool msg_is_ok = true;
bool handled =
resource_dispatcher_host_->OnMessageReceived(msg, this, &msg_is_ok) ||
- dom_storage_dispatcher_host_->OnMessageReceived(msg, &msg_is_ok) ||
indexed_db_dispatcher_host_->OnMessageReceived(msg) ||
db_dispatcher_host_->OnMessageReceived(msg, &msg_is_ok) ||
mp_dispatcher->OnMessageReceived(
@@ -619,8 +611,9 @@
void ResourceMessageFilter::OnMsgCreateWindow(
const ViewHostMsg_CreateWindow_Params& params,
int* route_id, int64* cloned_session_storage_namespace_id) {
- *cloned_session_storage_namespace_id = dom_storage_dispatcher_host_->
- CloneSessionStorage(params.session_storage_namespace_id);
+ *cloned_session_storage_namespace_id =
+ webkit_context_->dom_storage_context()->CloneSessionStorage(
+ params.session_storage_namespace_id);
render_widget_helper_->CreateNewWindow(params.opener_id,
params.user_gesture,
params.window_container_type,

Powered by Google App Engine
This is Rietveld 408576698