Linux: Add the debug link to our release executables and remove the obsolete ...

Linux: Remove obsolete dump_signature.py.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69058

[mmoss, 2010-12-12 18:14:13]

We already do this in stage_build.py (at least on the official builders). Is
this meant to replace that? If so, I think stage_build.py needs some reworking
to make sure it finds the .debug files for archiving, since that's currently
part of the strip step. Also, stage_build.py does this for all the build exes,
not just chrome.

Overall, it probably does make sense to move this to gyp, which could be smarter
about some things than stage_build.py. For instance, it's important to call the
version of objcopy which matches the linker used for the exe (e.g. gold,
crosstools, etc.). stage_build.py just hacks away at that (and currently punts
on chromeos), but gyp could probably determine the correct path and pass it into
dump_app_syms.

[Lei Zhang, 2010-12-13 19:55:07]

On 2010/12/12 18:14:13, mmoss wrote:
> We already do this in stage_build.py (at least on the official builders). Is
> this meant to replace that? If so, I think stage_build.py needs some reworking
> to make sure it finds the .debug files for archiving, since that's currently
> part of the strip step. Also, stage_build.py does this for all the build exes,
> not just chrome.
> 
> Overall, it probably does make sense to move this to gyp, which could be
smarter
> about some things than stage_build.py. For instance, it's important to call
the
> version of objcopy which matches the linker used for the exe (e.g. gold,
> crosstools, etc.). stage_build.py just hacks away at that (and currently punts
> on chromeos), but gyp could probably determine the correct path and pass it
into
> dump_app_syms.

Currently, the chrome binary in the archive contains the debug link, but the
chrome binary in the deb/rpm packages does not. This adds the debug link for the
binary that goes in the deb/rpm packages. Unfortunately this doesn't do it
right, since |linux_strip_binary| is only true for the Linux reliability bot,
and it would interfere with stage_build.py, since you can't run objcopy
--add-gnu-debuglink twice on a target binary.

[Lei Zhang, 2010-12-13 22:11:55]

I believe this has to happen in the internal installer. So I'm making this a
cleanup CL.

[mmoss, 2010-12-13 22:13:44]

LGTM