Issue 572037: Merge 38216 - Make Carbon plugin idle event source robust against changes dur...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 572037: Merge 38216 - Make Carbon plugin idle event source robust against changes dur... (Closed)

Created:
10 years, 10 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, John Grabowski, darin (slow to review), jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/307/src/

Visibility:
Public.

Description

Merge 38216 - Make Carbon plugin idle event source robust against changes during iteration Ensure that removing any plugin from the idle event source during iteration is safe (not just the currentlyfiring plugin). Also bulletproofs against the possibility of nested iteration. Refactors the idle event source to use a helper class, to reduce duplicate code. BUG=33467 TEST=Scroll rapidly on a page with multiple instances of a Cabon plugin. Review URL: http://codereview.chromium.org/575023 TBR=stuartmorgan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38223

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -56 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl_mac.mm	View		2 chunks	+61 lines, -56 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages