Issue 572034: Fix test failures in debug mode w/snapshots. It turns out that not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 572034: Fix test failures in debug mode w/snapshots. It turns out that not (Closed)

Created:
10 years, 10 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix test failures in debug mode w/snapshots. It turns out that not all stubs have valid major_keys, and this is OK. So I've added a check to avoid termination in debug mode. Committed: http://code.google.com/p/v8/source/detail?r=3807

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	src/code-stubs.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/code-stubs.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/disassembler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages