Issue 572024: Add a StatefulMemcpy which can be used to safely and iteratively copy blocks of memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 572024: Add a StatefulMemcpy which can be used to safely and iteratively copy blocks of memory. (Closed)

Created:
10 years, 10 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Add a StatefulMemcpy which can be used to safely and iteratively copy blocks of memory.

Patch Set 3 : Must be consistent.. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
M	src/platform/vboot_reference/common/utility_stub.c	View	1 2	3 chunks	+20 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/include/utility.h	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/utils/Makefile	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

http://codereview.chromium.org/572024/diff/1/2 File src/platform/vboot_reference/common/utility_stub.c (right): http://codereview.chromium.org/572024/diff/1/2#newcode53 src/platform/vboot_reference/common/utility_stub.c:53: void *saved_ptr; void*, right?

10 years, 10 months ago (2010-02-05 03:29:19 UTC) #2

gauravsh

10 years, 10 months ago (2010-02-05 03:32:47 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 572024: Add a StatefulMemcpy which can be used to safely and iteratively copy blocks of memory. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix Makefile. #

Patch Set 3 : Must be consistent.. #

Messages