Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: src/runtime.cc

Issue 572011: Fixed another presubmit error (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2902 matching lines...) Expand 10 before | Expand all | Expand 10 after
2913 } 2913 }
2914 return obj->DefineAccessor(name, flag_setter->value() == 0, fun, attr); 2914 return obj->DefineAccessor(name, flag_setter->value() == 0, fun, attr);
2915 } 2915 }
2916 2916
2917 static Object* Runtime_DefineOrRedefineDataProperty(Arguments args) { 2917 static Object* Runtime_DefineOrRedefineDataProperty(Arguments args) {
2918 ASSERT(args.length() == 4); 2918 ASSERT(args.length() == 4);
2919 HandleScope scope; 2919 HandleScope scope;
2920 CONVERT_ARG_CHECKED(JSObject, js_object, 0); 2920 CONVERT_ARG_CHECKED(JSObject, js_object, 0);
2921 CONVERT_ARG_CHECKED(String, name, 1); 2921 CONVERT_ARG_CHECKED(String, name, 1);
2922 Handle<Object> obj_value = args.at<Object>(2); 2922 Handle<Object> obj_value = args.at<Object>(2);
2923 2923
2924 CONVERT_CHECKED(Smi, flag, args[3]); 2924 CONVERT_CHECKED(Smi, flag, args[3]);
2925 int unchecked = flag->value(); 2925 int unchecked = flag->value();
2926 RUNTIME_ASSERT((unchecked & ~(READ_ONLY | DONT_ENUM | DONT_DELETE)) == 0); 2926 RUNTIME_ASSERT((unchecked & ~(READ_ONLY | DONT_ENUM | DONT_DELETE)) == 0);
2927 2927
2928 LookupResult result; 2928 LookupResult result;
2929 js_object->LocalLookupRealNamedProperty(*name, &result); 2929 js_object->LocalLookupRealNamedProperty(*name, &result);
2930 2930
2931 PropertyAttributes attr = static_cast<PropertyAttributes>(unchecked); 2931 PropertyAttributes attr = static_cast<PropertyAttributes>(unchecked);
2932 2932
2933 // Take special care when attributes are different and there is already 2933 // Take special care when attributes are different and there is already
(...skipping 5307 matching lines...) Expand 10 before | Expand all | Expand 10 after
8241 } else { 8241 } else {
8242 // Handle last resort GC and make sure to allow future allocations 8242 // Handle last resort GC and make sure to allow future allocations
8243 // to grow the heap without causing GCs (if possible). 8243 // to grow the heap without causing GCs (if possible).
8244 Counters::gc_last_resort_from_js.Increment(); 8244 Counters::gc_last_resort_from_js.Increment();
8245 Heap::CollectAllGarbage(false); 8245 Heap::CollectAllGarbage(false);
8246 } 8246 }
8247 } 8247 }
8248 8248
8249 8249
8250 } } // namespace v8::internal 8250 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698