Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 572005: Added extra tests to the DefineOrRedefineAccessorProperty and ... (Closed)

Created:
10 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added extra tests to the DefineOrRedefineAccessorProperty and DefineOrRedefineDataProperty to avoid invalid input. Added tests to object-define-property.js to test that it does not crash on invalid input. Committed: http://code.google.com/p/v8/source/detail?r=3798

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -9 lines) Patch
M src/runtime.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download
M test/mjsunit/object-define-property.js View 2 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
10 years, 10 months ago (2010-02-04 12:44:08 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/572005/diff/1/3 File src/runtime.cc (right): http://codereview.chromium.org/572005/diff/1/3#newcode2921 src/runtime.cc:2921: Handle<Object> name = args.at<Object>(1); Use CONVERT_CHECKED(String, name, args[1]) ...
10 years, 10 months ago (2010-02-04 15:08:42 UTC) #2
Rico
10 years, 10 months ago (2010-02-04 19:43:27 UTC) #3
http://codereview.chromium.org/572005/diff/1/3
File src/runtime.cc (right):

http://codereview.chromium.org/572005/diff/1/3#newcode2921
src/runtime.cc:2921: Handle<Object> name = args.at<Object>(1);
On 2010/02/04 15:08:42, Mads Ager wrote:
> Use CONVERT_CHECKED(String, name, args[1]) here and remove the RUNTIME_ASSERT
> and the Handle<String>::cast(name) from below.

Done.

Powered by Google App Engine
This is Rietveld 408576698