Added IsProperty() check to result in DefineOrRedefineAccessor - if no check ...

Added IsProperty() check to result in DefineOrRedefineAccessor - if no check 
this causes the debug check to fails since type() asserts that the 
lookup_type != NOT_FOUND. This does not change any functionality since we 
explicitly checked if it was one of the three types that we need to delete.
Also changed defineProperties in v8natives to actually return the object
being defined (as specified by spec)


Committed: http://code.google.com/p/v8/source/detail?r=3794

[Mads Ager (chromium), 2010-02-04 09:57:01]

http://codereview.chromium.org/572003/diff/2001/3002
File src/runtime.cc (right):

http://codereview.chromium.org/572003/diff/2001/3002#newcode2909
src/runtime.cc:2909: if (result.IsProperty() &&
I think you should use result.IsValid() here - no reason to check which type of
valid result it is more than once.

http://codereview.chromium.org/572003/diff/2001/3001
File src/v8natives.js (right):

http://codereview.chromium.org/572003/diff/2001/3001#newcode692
src/v8natives.js:692: return obj;
Could you please add a test for this missing return, or do we already have a
failing test for this?

[Rico, 2010-02-04 10:55:23]

Added object-define-properties.js test file to include test of return value from
Object.defineProperties (+ some extra tests)

http://codereview.chromium.org/572003/diff/2001/3002
File src/runtime.cc (right):

http://codereview.chromium.org/572003/diff/2001/3002#newcode2909
src/runtime.cc:2909: if (result.IsProperty() &&
On 2010/02/04 09:57:01, Mads Ager wrote:
> I think you should use result.IsValid() here - no reason to check which type
of
> valid result it is more than once.

Done.

[Mads Ager (chromium), 2010-02-04 11:25:33]

LGTM