Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 5720007: Check for enough room in /tmp, warn about too-small USB drives. (Closed)

Created:
10 years ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
scottz, Sumit
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Check for enough room in /tmp, warn about too-small USB drives. BUG=chromium-os:10062 TEST=manual Verify the tempdir check by specifying a working directory on a filesystem that's too small. It should complain: dd if=/dev/zero bs=1M count=3 of=foo mkfs.ext2 foo mount -o loop foo /mnt WORKDIR=/mnt ./recovery.sh Verify the too-small USB check by selecting one that's too small. It won't stop you, but will warn you like this: I found 2 USB drives. We need one with at least 927MB capacity. 0 - <quit> 1 - Use /dev/sdc 4051MB SanDisk U3 Cruzer Micro 2 - Use /dev/sdd 32MB M-Sys DiskOnKey Tell me what to do (or just press Enter to scan again): 2 WARNING: This drive seems too small (31MB). The recovery image is 927MB. Is this the device you want to put the recovery image on? /dev/sdd 32MB M-Sys DiskOnKey You must enter 'YES' (all uppercase) to continue: ^C Change-Id: I7cf78b5b69eba696d911ca8ee371909bcf3201c7 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9880ca5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -9 lines) Patch
M user_tools/linux/recovery.sh View 9 chunks +89 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Richardson
10 years ago (2010-12-14 22:40:54 UTC) #1
scottz
10 years ago (2010-12-14 22:58:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698