Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 5718005: API: Correct documentation of String::WriteUtf8, String::Write... (Closed)

Created:
10 years ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

API: Correct documentation of String::WriteUtf8, String::Write and String::WriteAscii and add test. Correct implementation of String::Write, fixing bug 975 (the patch in that bug was not used, however). Committed: http://code.google.com/p/v8/source/detail?r=6011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -13 lines) Patch
M include/v8.h View 1 chunk +8 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +124 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years ago (2010-12-14 12:33:11 UTC) #1
Mads Ager (chromium)
10 years ago (2010-12-14 12:54:13 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698