Issue 5717002: [Mac] Make profile-locking error the same as failing to lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5717002: [Mac] Make profile-locking error the same as failing to lock. (Closed)

Created:
10 years ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, Robert Sesek

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Make profile-locking error the same as failing to lock. Previously, the profile-locking code was conservative in the face of errors. Histograms indicate that the error rate is acceptable (no errors seen), so flip locking errors to me failure-to-lock. BUG=58986 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68871

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	chrome/browser/process_singleton_mac.cc	View		3 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Cleaning up an old bug. Zero hits to the histograms seems amazing (I'd expect at ...

10 years ago (2010-12-09 22:42:59 UTC) #1

LGTM

Expand Messages | Collapse Messages