Issue 5716007: Mac: Eliminiate @interface NoOp from base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5716007: Mac: Eliminiate @interface NoOp from base. (Closed)

Created:
10 years ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, dmac

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Eliminiate @interface NoOp from base. I don't think eliminating _all_ objc from base is the right answer -- the remaining objc has to move out of the static libbase. But if it's easy to have fewer objc to move, that's good. BUG=46929 TEST=One fewer duplicate symbol is reported when loading the pdf plugin. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69077

Patch Set 1 #

Patch Set 2 : call class, since initialize is guaranteed to run only once #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -17 lines)			Patch
	M	base/platform_thread_mac.mm	View	1	2 chunks	+3 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages