Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: net/http/http_auth_gssapi_posix.cc

Issue 5716004: Temporarily allow IO when loading shared GSSAPI library (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Also mention the bug ID in the comment Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_gssapi_posix.cc
diff --git a/net/http/http_auth_gssapi_posix.cc b/net/http/http_auth_gssapi_posix.cc
index bd2734f4a29a0cfdb5911a92d4565605034300ba..a162757f341ed77bff3dbd33a33d1229f3c5596c 100644
--- a/net/http/http_auth_gssapi_posix.cc
+++ b/net/http/http_auth_gssapi_posix.cc
@@ -13,6 +13,7 @@
#include "base/logging.h"
#include "base/string_util.h"
#include "base/stringprintf.h"
+#include "base/thread_restrictions.h"
#include "net/base/net_errors.h"
#include "net/base/net_util.h"
@@ -446,7 +447,12 @@ base::NativeLibrary GSSAPISharedLibrary::LoadSharedLibrary() {
for (size_t i = 0; i < num_lib_names; ++i) {
const char* library_name = library_names[i];
FilePath file_path(library_name);
+
+ // TODO: Move library loading to a separate thread. BUG(66702)
cbentzel 2010/12/13 22:00:46 Nit: Use http://crbug.com/66702 rather than BUG(66
+ base::ThreadRestrictions::ScopedAllowIO allow_io_temporarily;
+
cbentzel 2010/12/13 22:00:46 Nit: extra newline
base::NativeLibrary lib = base::LoadNativeLibrary(file_path);
+
cbentzel 2010/12/13 22:00:46 Nit: extra newline
if (lib) {
// Only return this library if we can bind the functions we need.
if (BindMethods(lib))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698