Temporarily allow IO when loading shared GSSAPI library

Temporarily allow IO when loading shared GSSAPI library

BUG=66702
TEST=none

Contributed by: asanka@google.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69148

[cbentzel, 2010-12-13 20:49:24]

[+evan,jam for the ThreadRestrictions::ScopedAllowIO, not sure what the appeals
process is]

Please change the BUG= to BUG=66702 (without chromium prefix)

Add a 
  Contributed By: asanka@google.com

to the CL description.

http://codereview.chromium.org/5716004/diff/1/net/http/http_auth_gssapi_posix.cc
File net/http/http_auth_gssapi_posix.cc (right):

http://codereview.chromium.org/5716004/diff/1/net/http/http_auth_gssapi_posix...
net/http/http_auth_gssapi_posix.cc:450: base::ThreadRestrictions::ScopedAllowIO
allow_io_temporarily;
Add a comment pointing to http://crbug.com/66702

[Evan Martin, 2010-12-13 20:52:22]

LGTM with a comment linking to the bug.  (Please also include a one-line
description of the bug, e.g. "TODO: move this off the IO thread", so that people
odn't have to click the link to know what the bug is about.)

[asanka (google), 2010-12-13 21:55:05]

> Please change the BUG= to BUG=66702 (without chromium prefix)
..
> Add a 
>   Contributed By: mailto:asanka@google.com
> 
> to the CL description.
> 

Done.

[asanka (google), 2010-12-13 21:56:28]

On 2010/12/13 20:52:22, Evan Martin wrote:
> LGTM with a comment linking to the bug.  (Please also include a one-line
> description of the bug, e.g. "TODO: move this off the IO thread", so that
people
> odn't have to click the link to know what the bug is about.)

Added.

[asanka (google), 2010-12-13 21:59:25]

Added new patch set that mentions the bug ID and fixed the CL description.

[cbentzel, 2010-12-13 22:00:46]

LGTM

I'll land this for you after you fix these nits.

http://codereview.chromium.org/5716004/diff/7001/net/http/http_auth_gssapi_po...
File net/http/http_auth_gssapi_posix.cc (right):

http://codereview.chromium.org/5716004/diff/7001/net/http/http_auth_gssapi_po...
net/http/http_auth_gssapi_posix.cc:451: // TODO: Move library loading to a
separate thread. BUG(66702)
Nit: Use http://crbug.com/66702 rather than BUG(66702)

http://codereview.chromium.org/5716004/diff/7001/net/http/http_auth_gssapi_po...
net/http/http_auth_gssapi_posix.cc:453: 
Nit: extra newline

http://codereview.chromium.org/5716004/diff/7001/net/http/http_auth_gssapi_po...
net/http/http_auth_gssapi_posix.cc:455: 
Nit: extra newline

[asanka (google), 2010-12-13 22:20:20]

On 2010/12/13 22:00:46, cbentzel wrote:
> LGTM
> 
> I'll land this for you after you fix these nits.
> 

Fixed.

[cbentzel, 2010-12-13 22:33:25]

LGTM

One more thing: Change the TODO to be of the form

TODO(asanka)

the linter caught this.

On Mon, Dec 13, 2010 at 5:20 PM, <asanka@google.com> wrote:

> On 2010/12/13 22:00:46, cbentzel wrote:
>
>> LGTM
>>
>
>  I'll land this for you after you fix these nits.
>>
>
>
> Fixed.
>
>
> http://codereview.chromium.org/5716004/
>

[asanka (google), 2010-12-13 22:41:03]

On 2010/12/13 22:33:25, cbentzel wrote:
> LGTM
> 
> One more thing: Change the TODO to be of the form
> 
> TODO(asanka)
> 
> the linter caught this.


Done.

[cbentzel, 2010-12-14 14:55:02]

http://codereview.chromium.org/5716004/diff/12002/net/http/http_auth_gssapi_p...
File net/http/http_auth_gssapi_posix.cc (right):

http://codereview.chromium.org/5716004/diff/12002/net/http/http_auth_gssapi_p...
net/http/http_auth_gssapi_posix.cc:451: // TODO(asanka): Move library loading to
a separate thread. http://crbug.com/66702
Nit: > 80 char line.

You can just move the URL to the next line.

[asanka (google), 2010-12-14 15:33:22]

>
http://codereview.chromium.org/5716004/diff/12002/net/http/http_auth_gssapi_p...
> net/http/http_auth_gssapi_posix.cc:451: // TODO(asanka): Move library loading
to
> a separate thread. http://crbug.com/66702
> Nit: > 80 char line.
> 
> You can just move the URL to the next line.

Done.