Improve our type feedback by recogizining never-executed IC calls for binary ...

src/ia32/lithium-codegen-ia32.cc

Index: src/ia32/lithium-codegen-ia32.cc
===================================================================
--- src/ia32/lithium-codegen-ia32.cc	(revision 5966)
+++ src/ia32/lithium-codegen-ia32.cc	(working copy)
@@ -1090,6 +1090,7 @@
 
   TypeRecordingBinaryOpStub stub(instr->op(), NO_OVERWRITE);
   CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
+  __ nop();  // Signals no inlined smi code.

[Vitaly Repeshko, 2010/12/10 13:38:56]

You can make CallCode emit the nop, if the code is a binary IC stub.

[fschneider, 2010/12/10 14:32:17]

Done. (also for the CompareIC)

 }
 
 
@@ -1681,6 +1682,7 @@
 
   Handle<Code> ic = CompareIC::GetUninitialized(op);
   CallCode(ic, RelocInfo::CODE_TARGET, instr);
+  __ nop();  // Signals no inlined smi code.
 
   Condition condition = ComputeCompareCondition(op);
   if (op == Token::GT || op == Token::LTE) {
@@ -1704,6 +1706,7 @@
 
   Handle<Code> ic = CompareIC::GetUninitialized(op);
   CallCode(ic, RelocInfo::CODE_TARGET, instr);
+  __ nop();  // Signals no inlined smi code.
 
   // The compare stub expects compare condition and the input operands
   // reversed for GT and LTE.