Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/type-info.cc

Issue 5714001: Improve our type feedback by recogizining never-executed IC calls for binary ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/ia32/full-codegen-ia32.cc ('K') | « src/ic.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 return unknown; 177 return unknown;
178 } 178 }
179 } else if (code->is_type_recording_binary_op_stub()) { 179 } else if (code->is_type_recording_binary_op_stub()) {
180 TRBinaryOpIC::TypeInfo type = static_cast<TRBinaryOpIC::TypeInfo>( 180 TRBinaryOpIC::TypeInfo type = static_cast<TRBinaryOpIC::TypeInfo>(
181 code->type_recording_binary_op_type()); 181 code->type_recording_binary_op_type());
182 TRBinaryOpIC::TypeInfo result_type = static_cast<TRBinaryOpIC::TypeInfo>( 182 TRBinaryOpIC::TypeInfo result_type = static_cast<TRBinaryOpIC::TypeInfo>(
183 code->type_recording_binary_op_result_type()); 183 code->type_recording_binary_op_result_type());
184 184
185 switch (type) { 185 switch (type) {
186 case TRBinaryOpIC::UNINITIALIZED: 186 case TRBinaryOpIC::UNINITIALIZED:
187 // Uninitialized state means never executed.
188 return unknown;
187 case TRBinaryOpIC::SMI: 189 case TRBinaryOpIC::SMI:
188 switch (result_type) { 190 switch (result_type) {
189 case TRBinaryOpIC::UNINITIALIZED: 191 case TRBinaryOpIC::UNINITIALIZED:
190 case TRBinaryOpIC::SMI: 192 case TRBinaryOpIC::SMI:
191 return TypeInfo::Smi(); 193 return TypeInfo::Smi();
192 case TRBinaryOpIC::INT32: 194 case TRBinaryOpIC::INT32:
193 return TypeInfo::Integer32(); 195 return TypeInfo::Integer32();
194 case TRBinaryOpIC::HEAP_NUMBER: 196 case TRBinaryOpIC::HEAP_NUMBER:
195 return TypeInfo::Double(); 197 return TypeInfo::Double();
196 default: 198 default:
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 source_positions->Add(position); 344 source_positions->Add(position);
343 } 345 }
344 } else { 346 } else {
345 ASSERT(RelocInfo::IsPosition(mode)); 347 ASSERT(RelocInfo::IsPosition(mode));
346 position = static_cast<int>(info->data()); 348 position = static_cast<int>(info->data());
347 } 349 }
348 } 350 }
349 } 351 }
350 352
351 } } // namespace v8::internal 353 } } // namespace v8::internal
OLDNEW
« src/ia32/full-codegen-ia32.cc ('K') | « src/ic.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698