Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 5713006: [cros] Clear any error messages when there's a connected network. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test for real Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/network_screen_browsertest.cc
diff --git a/chrome/browser/chromeos/login/network_screen_browsertest.cc b/chrome/browser/chromeos/login/network_screen_browsertest.cc
index 4802cef8ea64d8ee3448e15d97070c45a5012b3a..aa1e8454528e6ecdee5ef0373434934a539995a9 100644
--- a/chrome/browser/chromeos/login/network_screen_browsertest.cc
+++ b/chrome/browser/chromeos/login/network_screen_browsertest.cc
@@ -158,7 +158,8 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Ethernet) {
EXPECT_CALL(*mock_network_library_, ethernet_connected())
.WillOnce(Return(true));
EXPECT_CALL(*mock_network_library_, Connected())
- .WillOnce(Return(true));
+ .Times(2)
+ .WillRepeatedly(Return(true));
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
network_screen->OnNetworkManagerChanged(mock_network_library_);
@@ -199,7 +200,8 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Wifi) {
EXPECT_CALL(*mock_network_library_, ethernet_connected())
.WillOnce(Return(true));
EXPECT_CALL(*mock_network_library_, Connected())
- .WillOnce(Return(true));
+ .Times(2)
+ .WillRepeatedly(Return(true));
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
network_screen->OnNetworkManagerChanged(mock_network_library_);
@@ -238,7 +240,8 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Cellular) {
EXPECT_CALL(*mock_network_library_, ethernet_connected())
.WillOnce(Return(true));
EXPECT_CALL(*mock_network_library_, Connected())
- .WillOnce(Return(true));
+ .Times(2)
+ .WillRepeatedly(Return(true));
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
network_screen->OnNetworkManagerChanged(mock_network_library_);
@@ -273,7 +276,8 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Timeout) {
network_screen->OnNetworkManagerChanged(mock_network_library_);
EXPECT_CALL(*mock_network_library_, Connected())
- .WillOnce(Return(false));
+ .Times(2)
+ .WillRepeatedly(Return(false));
EXPECT_FALSE(network_view->IsContinueEnabled());
EXPECT_FALSE(network_view->IsConnecting());
network_screen->OnConnectionTimeout();
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698