Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 5713006: [cros] Clear any error messages when there's a connected network. (Closed)

Created:
10 years ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
glotov
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[cros] Clear any error messages when there's a connected network. BUG=chromium-os:9959 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69125

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : remove constant value back #

Patch Set 4 : fix test for real #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/browser/chromeos/login/network_screen.cc View 2 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 1 2 3 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
10 years ago (2010-12-13 12:50:50 UTC) #1
Nikita (slow)
TabCloseableStateWatcherTest.CloseBrowserWithBeforeUnloadHandlerCancel: test failure is flaky test and unrelated
10 years ago (2010-12-13 16:30:31 UTC) #2
glotov
10 years ago (2010-12-14 12:27:39 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698