Issue 5712009: Increase the initial spdy concurrent stream limit to 10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5712009: Increase the initial spdy concurrent stream limit to 10 (Closed)

Created:
10 years ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Increase the initial spdy concurrent stream limit to 10 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69176

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/spdy/spdy_session.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

10 years ago (2010-12-14 19:06:05 UTC) #2

LGTM

On Tue, Dec 14, 2010 at 9:29 AM, <mbelshe@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Increase the initial spdy concurrent stream limit to 10
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/5712009/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     net/spdy/spdy_session.h
>
>
> Index: net/spdy/spdy_session.h
> ===================================================================
> --- net/spdy/spdy_session.h     (revision 69022)
> +++ net/spdy/spdy_session.h     (working copy)
> @@ -207,7 +207,7 @@
>     CLOSED
>   };
>
> -  enum { kDefaultMaxConcurrentStreams = 6 };  // TODO(mbelshe) remove this
> +  enum { kDefaultMaxConcurrentStreams = 10 };
>
>   struct PendingCreateStream {
>     const GURL* url;
>
>
>

Expand Messages | Collapse Messages