Create base::WorkerPoolJob. Use it for HostResolverImpl and DirectoryLister.

net/url_request/url_request_file_dir_job.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_file_dir_job.h"
 
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/io_buffer.h"
+#include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request.h"
 
 #if defined(OS_POSIX)
 #include <sys/stat.h>
 #endif
 
-using std::string;
-
 URLRequestFileDirJob::URLRequestFileDirJob(net::URLRequest* request,
                                            const FilePath& dir_path)
     : URLRequestJob(request),
+      ALLOW_THIS_IN_INITIALIZER_LIST(lister_(dir_path, this)),
       dir_path_(dir_path),
       canceled_(false),
       list_complete_(false),
       wrote_header_(false),
       read_pending_(false),
       read_buffer_length_(0),
       ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)) {
 }
 
 URLRequestFileDirJob::~URLRequestFileDirJob() {
-  DCHECK(read_pending_ == false);
-  DCHECK(lister_ == NULL);
+  DCHECK(!read_pending_);
 }
 
 void URLRequestFileDirJob::Start() {
   // Start reading asynchronously so that all error reporting and data
   // callbacks happen as they would for network requests.
   MessageLoop::current()->PostTask(
       FROM_HERE,
       method_factory_.NewRunnableMethod(
           &URLRequestFileDirJob::StartAsync));
 }
 
 void URLRequestFileDirJob::StartAsync() {
-  DCHECK(!lister_);
-
-  // TODO(willchan): This is stupid.  We should tell |lister_| not to call us
-  // back.  Fix this stupidity.
-
-  // AddRef so that *this* cannot be destroyed while the lister_
-  // is trying to feed us data.
-
-  AddRef();
-  lister_ = new net::DirectoryLister(dir_path_, this);
-  lister_->Start();
+  lister_.Start();
 
   NotifyHeadersComplete();
 }
 
 void URLRequestFileDirJob::Kill() {
-  if (canceled_)
-    return;
+  if (!is_done() && !list_complete_) {
+    lister_.Cancel();
+    read_pending_ = false;
+    list_complete_ = true;
+  }
 
-  canceled_ = true;
-
-  // Don't call CloseLister or dispatch an error to the net::URLRequest because
-  // we want OnListDone to be called to also write the error to the output
-  // stream. OnListDone will notify the net::URLRequest at this time.
-  if (lister_)
-    lister_->Cancel();
+  DCHECK(!read_pending_);
+  DCHECK(list_complete_);
+  method_factory_.RevokeAll();
 
   URLRequestJob::Kill();
-
-  method_factory_.RevokeAll();
 }
 
 bool URLRequestFileDirJob::ReadRawData(net::IOBuffer* buf, int buf_size,
                                        int *bytes_read) {
   DCHECK(bytes_read);
   *bytes_read = 0;
 
   if (is_done())
     return true;
 
   if (FillReadBuffer(buf->data(), buf_size, bytes_read))
     return true;
 
   // We are waiting for more data
   read_pending_ = true;
   read_buffer_ = buf;
   read_buffer_length_ = buf_size;
   SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
   return false;
 }
 
-bool URLRequestFileDirJob::GetMimeType(string* mime_type) const {
+bool URLRequestFileDirJob::GetMimeType(std::string* mime_type) const {
   *mime_type = "text/html";
   return true;
 }
 
-bool URLRequestFileDirJob::GetCharset(string* charset) {
+bool URLRequestFileDirJob::GetCharset(std::string* charset) {
   // All the filenames are converted to UTF-8 before being added.
   *charset = "utf-8";
   return true;
 }
 
-void URLRequestFileDirJob::OnListFile(
-    const net::DirectoryLister::DirectoryListerData& data) {
+void URLRequestFileDirJob::OnListFile(const net::DirectoryLister::Data& data) {
   // We wait to write out the header until we get the first file, so that we
   // can catch errors from DirectoryLister and show an error page.
   if (!wrote_header_) {
 #if defined(OS_WIN)
     const string16& title = dir_path_.value();
 #elif defined(OS_POSIX)
     // TODO(jungshik): Add SysNativeMBToUTF16 to sys_string_conversions.
     // On Mac, need to add NFKC->NFC conversion either here or in file_path.
     // On Linux, the file system encoding is not defined, but we assume that
     // SysNativeMBToWide takes care of it at least for now. We can try something
@@ skipping 26 matching lines @@
       S_ISDIR(data.info.stat.st_mode),
       data.info.stat.st_size,
       base::Time::FromTimeT(data.info.stat.st_mtime)));
 #endif
 
   // TODO(darin): coalesce more?
   CompleteRead();
 }
 
 void URLRequestFileDirJob::OnListDone(int error) {
-  CloseLister();
-
-  if (canceled_) {
-    read_pending_ = false;
-    // No need for NotifyCanceled() since canceled_ is set inside Kill().
-  } else if (error) {
+  if (error != net::OK) {
     read_pending_ = false;
     NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, error));
   } else {
     list_complete_ = true;
     CompleteRead();
   }
-
-  Release();  // The Lister is finished; may delete *this*
-}
-
-void URLRequestFileDirJob::CloseLister() {
-  if (lister_) {
-    lister_->Cancel();
-    lister_->set_delegate(NULL);
-    lister_ = NULL;
-  }
 }
 
 bool URLRequestFileDirJob::FillReadBuffer(char *buf, int buf_size,
                                           int *bytes_read) {
   DCHECK(bytes_read);
 
   *bytes_read = 0;
 
   int count = std::min(buf_size, static_cast<int>(data_.size()));
   if (count) {
@@ skipping 20 matching lines @@
 
       SetStatus(URLRequestStatus());
       NotifyReadComplete(bytes_read);
     } else {
       NOTREACHED();
       // TODO: Better error code.
       NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, 0));
     }
   }
 }