Create base::WorkerPoolJob. Use it for HostResolverImpl and DirectoryLister.

chrome/browser/file_select_helper.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/file_select_helper.h"
 
 #include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "net/base/mime_util.h"
+#include "net/base/net_errors.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/renderer_host/render_widget_host_view.h"
 #include "chrome/browser/shell_dialogs.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_view.h"
 #include "chrome/common/notification_details.h"
 #include "chrome/common/notification_source.h"
 #include "chrome/common/render_messages_params.h"
 #include "grit/generated_resources.h"
 
 FileSelectHelper::FileSelectHelper(Profile* profile)
     : profile_(profile),
       render_view_host_(NULL),
       select_file_dialog_(),
       dialog_type_(SelectFileDialog::SELECT_OPEN_FILE) {
 }
 
 FileSelectHelper::~FileSelectHelper() {
   // There may be pending file dialogs, we need to tell them that we've gone
   // away so they don't try and call back to us.
   if (select_file_dialog_.get())
     select_file_dialog_->ListenerDestroyed();
-
-  // Stop any pending directory enumeration and prevent a callback.
-  if (directory_lister_.get()) {
-    directory_lister_->set_delegate(NULL);
-    directory_lister_->Cancel();
-  }
 }
 
 void FileSelectHelper::FileSelected(const FilePath& path,
                                     int index, void* params) {
   if (!render_view_host_)
     return;
 
   profile_->set_last_selected_directory(path.DirName());
 
   if (dialog_type_ == SelectFileDialog::SELECT_FOLDER) {
@@ skipping 26 matching lines @@
 
   // If the user cancels choosing a file to upload we pass back an
   // empty vector.
   render_view_host_->FilesSelectedInChooser(std::vector<FilePath>());
 
   // We are done with this showing of the dialog.
   render_view_host_ = NULL;
 }
 
 void FileSelectHelper::DirectorySelected(const FilePath& path) {
-  directory_lister_ = new net::DirectoryLister(path,
-                                               true,
-                                               net::DirectoryLister::NO_SORT,
-                                               this);
-  if (!directory_lister_->Start())
-    FileSelectionCanceled(NULL);
+  directory_lister_.reset(
+      new net::DirectoryLister(path,
+                               true,
+                               net::DirectoryLister::NO_SORT,
+                               this));
+  directory_lister_->Start();
 }
 
-void FileSelectHelper::OnListFile(
-    const net::DirectoryLister::DirectoryListerData& data) {
+void FileSelectHelper::OnListFile(const net::DirectoryLister::Data& data) {
   // Directory upload only cares about files.  This util call just checks
   // the flags in the structure; there's no file I/O going on.
   if (file_util::FileEnumerator::IsDirectory(data.info))
     return;
 
   directory_lister_results_.push_back(data.path);
 }
 
 void FileSelectHelper::OnListDone(int error) {
   if (!render_view_host_)
     return;
 
-  if (error) {
+  if (error != net::OK) {
     FileSelectionCanceled(NULL);
     return;
   }
 
   render_view_host_->FilesSelectedInChooser(directory_lister_results_);
   render_view_host_ = NULL;
-  directory_lister_ = NULL;
+  directory_lister_.reset();
   directory_lister_results_.clear();
 }
 
 SelectFileDialog::FileTypeInfo* FileSelectHelper::GetFileTypesFromAcceptType(
     const string16& accept_types) {
   if (accept_types.empty())
     return NULL;
 
   // Split the accept-type string on commas.
   std::vector<string16> mime_types;
@@ skipping 104 matching lines @@
                                   NULL);
 }
 
 void FileSelectHelper::Observe(NotificationType type,
                                const NotificationSource& source,
                                const NotificationDetails& details) {
   DCHECK(type == NotificationType::RENDER_WIDGET_HOST_DESTROYED);
   DCHECK(Details<RenderViewHost>(details).ptr() == render_view_host_);
   render_view_host_ = NULL;
 }