Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Unified Diff: chrome/browser/chromeos/login/user_view.cc

Issue 5709001: Place the spinner in the right corner of the controls window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login
Patch Set: code review Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_view.cc
diff --git a/chrome/browser/chromeos/login/user_view.cc b/chrome/browser/chromeos/login/user_view.cc
index 1434a8a104e5d311ff3424a591dad0af4804b7cb..838ad28901872d6799b48b62e533913f6dadb1eb 100644
--- a/chrome/browser/chromeos/login/user_view.cc
+++ b/chrome/browser/chromeos/login/user_view.cc
@@ -19,7 +19,6 @@
#include "views/controls/image_view.h"
#include "views/controls/label.h"
#include "views/controls/link.h"
-#include "views/controls/throbber.h"
#include "views/painter.h"
namespace {
@@ -243,7 +242,6 @@ UserView::UserView(Delegate* delegate, bool is_login, bool need_background)
: delegate_(delegate),
signout_view_(NULL),
image_view_(new RoundedView<PodImageView>),
- throbber_(CreateDefaultSmoothedThrobber()),
remove_button_(NULL) {
DCHECK(delegate);
if (!is_login)
@@ -257,16 +255,6 @@ void UserView::Init(bool need_background) {
image_view_->set_background(
views::Background::CreateSolidBackground(kBackgroundColor));
}
- if (throbber_) {
- int w = throbber_->GetPreferredSize().width();
- int h = throbber_->GetPreferredSize().height();
- throbber_->SetBounds(kUserImageSize / 2 - w / 2,
- kUserImageSize / 2 - h / 2 , w, h);
- // Throbber should be actually hidden while stopped so tooltip manager
- // doesn't find it.
- throbber_->SetVisible(false);
- image_view_->AddChildView(throbber_);
- }
// UserView's layout never changes, so let's layout once here.
image_view_->SetBounds(0, 0, kUserImageSize, kUserImageSize);
@@ -302,16 +290,6 @@ void UserView::SetTooltipText(const std::wstring& text) {
image_view_->SetTooltipText(text);
}
-void UserView::StartThrobber() {
- throbber_->SetVisible(true);
- throbber_->Start();
-}
-
-void UserView::StopThrobber() {
- throbber_->Stop();
- throbber_->SetVisible(false);
-}
-
gfx::Size UserView::GetPreferredSize() {
return gfx::Size(
kUserImageSize,
« chrome/browser/chromeos/login/user_input.h ('K') | « chrome/browser/chromeos/login/user_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698