Place the spinner in the right corner of the controls window.

chrome/browser/chromeos/login/existing_user_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_view.h"
 
 #include "app/l10n_util.h"
-#include "chrome/browser/chromeos/login/helper.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/chromeos/login/user_controller.h"
 #include "chrome/browser/chromeos/login/textfield_with_margin.h"
 #include "chrome/browser/chromeos/login/wizard_accessibility_helper.h"
 #include "grit/generated_resources.h"
 #include "views/background.h"
 #include "views/focus/focus_manager.h"
 #include "views/fill_layout.h"
 
 namespace chromeos {
 
 // Colors for gradient background. These should be consistent with border
 // window background so textfield border is not visible to the user.
 // The background is needed for password textfield to imitate its borders
 // transparency correctly.
 const SkColor kBackgroundColorTop = SkColorSetRGB(209, 213, 216);
 const SkColor kBackgroundColorBottom = SkColorSetRGB(205, 210, 213);
 
 // Textfield with custom processing for Tab/Shift+Tab to select entries.
 class UserEntryTextfield : public TextfieldWithMargin {
  public:
   UserEntryTextfield(UserController* controller,
                      views::Textfield::StyleFlags style)
       : TextfieldWithMargin(style),
         controller_(controller) {}
 
   // Overridden from views::View:
   virtual bool OnKeyPressed(const views::KeyEvent& e) {
     if (e.GetKeyCode() == app::VKEY_TAB) {
-      int index = controller_->user_index() + (e.IsShiftDown() ? -1 : 1);
-      controller_->SelectUser(index);
+      controller_->SelectUserRelative(e.IsShiftDown() ? -1 : 1);
       return true;
     } else {
       return false;
     }
   }
 
   virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e) {
     if (e.GetKeyCode() == app::VKEY_TAB)
       return true;
     else
       return views::Textfield::SkipDefaultKeyEventProcessing(e);
   }
 
  private:
   UserController* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(UserEntryTextfield);
 };
 
 
-ExistingUserView::ExistingUserView(UserController* uc)
-    : accel_login_off_the_record_(
+ExistingUserView::ExistingUserView(UserController* user_controller)
+    : ThrobberHost(this),
+      user_controller_(user_controller),
+      password_field_(NULL),
+      accel_login_off_the_record_(
         views::Accelerator(app::VKEY_B, false, false, true)),
-      password_field_(NULL),
-      user_controller_(uc),
       accel_enable_accessibility_(
           WizardAccessibilityHelper::GetAccelerator()) {
   AddAccelerator(accel_login_off_the_record_);
   AddAccelerator(accel_enable_accessibility_);
 }
 
 void ExistingUserView::RecreateFields() {
   if (password_field_ == NULL) {
     SetLayoutManager(new views::FillLayout);
     password_field_ = new UserEntryTextfield(user_controller_,
                                              views::Textfield::STYLE_PASSWORD);
     password_field_->set_background(
         views::Background::CreateVerticalGradientBackground(
             kBackgroundColorTop, kBackgroundColorBottom));
     password_field_->SetFocusable(true);
-    password_field_->SetController(user_controller_);
+    password_field_->SetController(this);
     AddChildView(password_field_);
   }
   password_field_->set_text_to_display_when_empty(
       l10n_util::GetStringUTF16(IDS_LOGIN_POD_EMPTY_PASSWORD_TEXT));
   Layout();
   SchedulePaint();
 }
 
 bool ExistingUserView::AcceleratorPressed(
     const views::Accelerator& accelerator) {
   if (accelerator == accel_login_off_the_record_) {
     user_controller_->OnLoginOffTheRecord();
     return true;
   } else if (accelerator == accel_enable_accessibility_) {
     WizardAccessibilityHelper::GetInstance()->EnableAccessibility(this);
     return true;
   }
   return false;
 }
 
+bool ExistingUserView::HandleKeystroke(
+    views::Textfield* sender,
+    const views::Textfield::Keystroke& keystroke) {
+  if (keystroke.GetKeyboardCode() == app::VKEY_RETURN) {
+    user_controller_->OnLogin("", UTF16ToUTF8(password_field_->text()));
+  } else if (keystroke.GetKeyboardCode() == app::VKEY_LEFT) {
+    user_controller_->SelectUserRelative(-1);
+  } else if (keystroke.GetKeyboardCode() == app::VKEY_RIGHT) {
+    user_controller_->SelectUserRelative(1);
+  } else {
+    user_controller_->ClearErrors();
+    return false;
+  }
+

[whywhat, 2010/12/13 16:10:55]

This blank line is not needed imho.

[altimofeev, 2010/12/14 11:15:21]

Done.

+  return true;
+}
+
+void ExistingUserView::ContentsChanged(views::Textfield* sender,
+                                       const string16& new_contents) {
+}
+
+void ExistingUserView::EnableInputControls(bool enabled) {
+  password_field_->SetEnabled(enabled);
+}
+
+void ExistingUserView::ClearAndFocusControls() {
+  ClearAndFocusPassword();
+}
+
+void ExistingUserView::ClearAndFocusPassword() {
+  password_field_->SetText(string16());
+  FocusPasswordField();
+}
+
 void ExistingUserView::ViewHierarchyChanged(bool is_add,
                                             views::View* parent,
                                             views::View* child) {
   if (is_add && this == child)
     WizardAccessibilityHelper::GetInstance()->MaybeEnableAccessibility(this);
 }
 
 void ExistingUserView::FocusPasswordField() {
-  if (GetFocusManager()) {
-    password_field()->RequestFocus();
-  }
+  password_field_->RequestFocus();
+}
+
+gfx::Rect ExistingUserView::GetMainInputScreenBounds() const {
+  return password_field_->GetScreenBounds();
 }
 
 void ExistingUserView::OnLocaleChanged() {
   RecreateFields();
 }
 
 }  // namespace chromeos