Place the spinner in the right corner of the controls window.

chrome/browser/chromeos/login/screen_locker.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/screen_locker.h"
 
 #include <gdk/gdkx.h>
 #include <string>
 #include <vector>
 #include <X11/extensions/XTest.h>
@@ skipping 14 matching lines @@
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/chromeos/cros/input_method_library.h"
 #include "chrome/browser/chromeos/cros/keyboard_library.h"
 #include "chrome/browser/chromeos/cros/login_library.h"
 #include "chrome/browser/chromeos/cros/screen_lock_library.h"
 #include "chrome/browser/chromeos/language_preferences.h"
 #include "chrome/browser/chromeos/login/authenticator.h"
 #include "chrome/browser/chromeos/login/background_view.h"
+#include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/login_performer.h"
 #include "chrome/browser/chromeos/login/login_utils.h"
 #include "chrome/browser/chromeos/login/message_bubble.h"
 #include "chrome/browser/chromeos/login/screen_lock_view.h"
 #include "chrome/browser/chromeos/login/shutdown_button.h"
 #include "chrome/browser/chromeos/system_key_event_listener.h"
 #include "chrome/browser/chromeos/wm_ipc.h"
 #include "chrome/browser/metrics/user_metrics.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/sync/profile_sync_service.h"
@@ skipping 570 matching lines @@
       lock_widget_(NULL),
       screen_lock_view_(NULL),
       user_(user),
       error_info_(NULL),
       drawn_(false),
       input_grabbed_(false),
       // TODO(oshima): support auto login mode (this is not implemented yet)
       // http://crosbug.com/1881
       unlock_on_input_(user_.email().empty()),
       locked_(false),
-      start_time_(base::Time::Now()) {
+      start_time_(base::Time::Now()),
+      throbber_manager_(new ThrobberManager) {
   DCHECK(!screen_locker_);
   screen_locker_ = this;
 }
 
 void ScreenLocker::Init() {
   authenticator_ = LoginUtils::Get()->CreateAuthenticator(this);
 
   gfx::Point left_top(1, 1);
   gfx::Rect init_bounds(views::Screen::GetMonitorAreaNearestPoint(left_top));
 
   LockWindow* lock_window = new LockWindow();
   lock_window_ = lock_window;
   lock_window_->Init(NULL, init_bounds);
 
   g_signal_connect(lock_window_->GetNativeView(), "client-event",
                    G_CALLBACK(OnClientEventThunk), this);
 
   // GTK does not like zero width/height.
   if (!unlock_on_input_) {
     screen_lock_view_ = new ScreenLockView(this);
     screen_lock_view_->Init();
     screen_lock_view_->SetEnabled(false);
+    StartThrobber();

[Nikita (slow), 2010/12/09 15:33:22]

As I understand this throbber is shown while ScreenLock acquires grab.
Does it work?

   } else {
     input_event_observer_.reset(new InputEventObserver(this));
     MessageLoopForUI::current()->AddObserver(input_event_observer_.get());
   }
 
   // Hang on to a cast version of the grab widget so we can call its
   // TryGrabAllInputs() method later.  (Nobody else needs to use it, so moving
   // its declaration to the header instead of keeping it in an anonymous
   // namespace feels a bit ugly.)
   GrabWidget* cast_lock_widget = new GrabWidget(this);
@@ skipping 116 matching lines @@
   if (mouse_event_relay_.get()) {
     MessageLoopForUI::current()->RemoveObserver(mouse_event_relay_.get());
     mouse_event_relay_.reset();
   }
 }
 
 void ScreenLocker::Authenticate(const string16& password) {
   authentication_start_time_ = base::Time::Now();
   screen_lock_view_->SetEnabled(false);
   screen_lock_view_->SetSignoutEnabled(false);
+  StartThrobber();
 
   // If LoginPerformer instance exists,
   // initial online login phase is still active.
   if (LoginPerformer::default_performer()) {
     DVLOG(1) << "Delegating authentication to LoginPerformer.";
     LoginPerformer::default_performer()->Login(user_.email(),
                                                UTF16ToUTF8(password));
   } else {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         NewRunnableMethod(authenticator_.get(),
                           &Authenticator::AuthenticateToUnlock,
                           user_.email(),
                           UTF16ToUTF8(password)));
   }
 }
 
 void ScreenLocker::ClearErrors() {
   if (error_info_) {
     error_info_->Close();
     error_info_ = NULL;
   }
 }
 
 void ScreenLocker::EnableInput() {
   if (screen_lock_view_) {
     screen_lock_view_->SetEnabled(true);
     screen_lock_view_->ClearAndSetFocusToPassword();
+    StopThrobber();
   }
 }
 
 void ScreenLocker::Signout() {
   if (!error_info_) {
     UserMetrics::RecordAction(UserMetricsAction("ScreenLocker_Signout"));
     if (CrosLibrary::Get()->EnsureLoaded()) {
       CrosLibrary::Get()->GetLoginLibrary()->StopSession("");
     }
 
     // Don't hide yet the locker because the chrome screen may become visible
     // briefly.
   }
 }
 
 void ScreenLocker::ShowErrorMessage(const std::wstring& message,
                                     bool sign_out_only) {
   if (sign_out_only) {
     screen_lock_view_->SetEnabled(false);
+    StartThrobber();

[Nikita (slow), 2010/12/09 15:33:22]

Why show throbber along with error bubble?

[oshima, 2010/12/09 21:52:10]

may be this is a bug from http://codereview.chromium.org/3583013

[altimofeev, 2010/12/10 16:37:40]

Oshima-san is right. I have automatically copied the previous behavior of the
'SetEnabled(false)' call.

Fixed.

   } else {
     EnableInput();
   }
   screen_lock_view_->SetSignoutEnabled(sign_out_only);
   // Make sure that active Sign Out button is not hidden behind the bubble.
   ShowErrorBubble(message, sign_out_only ?
       BubbleBorder::BOTTOM_RIGHT : BubbleBorder::BOTTOM_LEFT);
 }
 
 void ScreenLocker::OnGrabInputs() {
@@ skipping 88 matching lines @@
   screen_locker_ = NULL;
   bool state = false;
   NotificationService::current()->Notify(
       NotificationType::SCREEN_LOCK_STATE_CHANGED,
       Source<ScreenLocker>(this),
       Details<bool>(&state));
   if (CrosLibrary::Get()->EnsureLoaded())
     CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenUnlockCompleted();
 }
 
+void ScreenLocker::StartThrobber() {
+  views::Widget* widget_under_throbber =
+      screen_lock_view_->GetWidgetForThrobber();
+  if (widget_under_throbber) {
+    throbber_manager_->StartShow(widget_under_throbber,
+                                 CreateDefaultSmoothedThrobber(),
+                                 login::kThrobberRightShift);
+  }
+}
+
+void ScreenLocker::StopThrobber() {
+  throbber_manager_->Stop();
+}
+
 void ScreenLocker::SetAuthenticator(Authenticator* authenticator) {
   authenticator_ = authenticator;
 }
 
 void ScreenLocker::ScreenLockReady() {
   VLOG(1) << "ScreenLockReady: sending completed signal to power manager.";
   locked_ = true;
   base::TimeDelta delta = base::Time::Now() - start_time_;
   VLOG(1) << "Screen lock time: " << delta.InSecondsF();
   UMA_HISTOGRAM_TIMES("ScreenLocker.ScreenLockTime", delta);
@@ skipping 88 matching lines @@
 
 bool ScreenLocker::AcceleratorPressed(const views::Accelerator& accelerator) {
   if (!background_view_->IsScreenSaverVisible()) {
     StartScreenSaver();
     return true;
   }
   return false;
 }
 
 }  // namespace chromeos