Place the spinner in the right corner of the controls window.

chrome/browser/chromeos/login/new_user_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/new_user_view.h"
 
 #include <signal.h>
 #include <sys/types.h>
 
 #include <algorithm>
@@ skipping 77 matching lines @@
       title_label_(NULL),
       title_hint_label_(NULL),
       splitter_up1_(NULL),
       splitter_up2_(NULL),
       splitter_down1_(NULL),
       splitter_down2_(NULL),
       sign_in_button_(NULL),
       create_account_link_(NULL),
       guest_link_(NULL),
       languages_menubutton_(NULL),
-      throbber_(NULL),
       accel_focus_pass_(views::Accelerator(app::VKEY_P, false, false, true)),

[whywhat, 2010/12/09 16:20:18]

Do we need to initialize throbber positions here too?

[altimofeev, 2010/12/10 16:37:40]

Added impossible initial value for |throbber_center_y| to be able distinguish
when it hasn't been calculated yet.

       accel_focus_user_(views::Accelerator(app::VKEY_U, false, false, true)),
       accel_login_off_the_record_(
           views::Accelerator(app::VKEY_B, false, false, true)),
       accel_enable_accessibility_(WizardAccessibilityHelper::GetAccelerator()),
       delegate_(delegate),
       ALLOW_THIS_IN_INITIALIZER_LIST(focus_grabber_factory_(this)),
       focus_delayed_(false),
       login_in_process_(false),
       need_border_(need_border),
       need_guest_link_(false),
@@ skipping 41 matching lines @@
   splitter_down2_ = CreateSplitter(kSplitterDown2Color);
 
   username_field_ = new UsernameField();
   username_field_->set_background(new CopyBackground(this));
   AddChildView(username_field_);
 
   password_field_ = new TextfieldWithMargin(views::Textfield::STYLE_PASSWORD);
   password_field_->set_background(new CopyBackground(this));
   AddChildView(password_field_);
 
-  throbber_ = CreateDefaultSmoothedThrobber();
-  AddChildView(throbber_);
-
   language_switch_menu_.InitLanguageMenu();
 
   RecreatePeculiarControls();
 
   AddChildView(sign_in_button_);
   if (need_create_account_) {
     InitLink(&create_account_link_);
   }
   if (need_guest_link_) {
     InitLink(&guest_link_);
@@ skipping 239 matching lines @@
            sign_in_button_->GetPreferredSize().height() +
            2 * kRowPad;
   y = title_end + (bottom_start - title_end - height) / 2;
 
   y += setViewBounds(username_field_, x, y, width, true) + kRowPad;
   y += setViewBounds(password_field_, x, y, width, true) + kRowPad;
 
   int throbber_y = y;
   int sign_in_button_width = sign_in_button_->GetPreferredSize().width();
   setViewBounds(sign_in_button_, x, y, sign_in_button_width,true);
-  setViewBounds(throbber_,
-                x + width - throbber_->GetPreferredSize().width(),
-                throbber_y + (sign_in_button_->GetPreferredSize().height() -
-                              throbber_->GetPreferredSize().height()) / 2,
-                width,
-                false);
+
+
+  throbber_right_ = x + width;
+  throbber_center_y_ =
+      throbber_y + sign_in_button_->GetPreferredSize().height() / 2;
 
   SchedulePaint();
 }
 
 gfx::Size NewUserView::GetPreferredSize() {
   return need_guest_link_ ?
       gfx::Size(kNewUserPodFullWidth, kNewUserPodFullHeight) :
       gfx::Size(kNewUserPodSmallWidth, kNewUserPodSmallHeight);
 }
 
 void NewUserView::SetUsername(const std::string& username) {
   username_field_->SetText(UTF8ToUTF16(username));
 }
 
 void NewUserView::SetPassword(const std::string& password) {
   password_field_->SetText(UTF8ToUTF16(password));
 }
 
 void NewUserView::Login() {
   if (login_in_process_ || username_field_->text().empty())
     return;
 
-  StartThrobber();
   login_in_process_ = true;
-  EnableInputControls(false);
   std::string username = UTF16ToUTF8(username_field_->text());
   // todo(cmasone) Need to sanitize memory used to store password.
   std::string password = UTF16ToUTF8(password_field_->text());
 
   if (username.find('@') == std::string::npos) {
     username += kDefaultDomain;
     username_field_->SetText(UTF8ToUTF16(username));
   }
 
   delegate_->OnLogin(username, password);
 }
 
 // Sign in button causes a login attempt.
 void NewUserView::ButtonPressed(views::Button* sender,
                                 const views::Event& event) {
   DCHECK(sender == sign_in_button_);
   Login();
 }
 
 void NewUserView::LinkActivated(views::Link* source, int event_flags) {
   if (source == create_account_link_) {
     delegate_->OnCreateAccount();
   } else if (source == guest_link_) {
     delegate_->OnLoginOffTheRecord();
   }
 }
 
-void NewUserView::ClearAndEnablePassword() {
+void NewUserView::ClearAndFocusControls() {
   login_in_process_ = false;
-  EnableInputControls(true);
-  SetPassword(std::string());
-  password_field_->RequestFocus();
-  StopThrobber();
-}
-
-void NewUserView::ClearAndEnableFields() {
-  login_in_process_ = false;
-  EnableInputControls(true);
   SetUsername(std::string());
   SetPassword(std::string());
   username_field_->RequestFocus();
-  StopThrobber();
+}
+
+void NewUserView::ClearAndFocusPassword() {
+  login_in_process_ = false;
+  SetPassword(std::string());
+  password_field_->RequestFocus();
+}
+
+gfx::Rect NewUserView::GetControlWithErrorBounds() const {
+  return GetUsernameBounds();
+}
+
+bool NewUserView::UseCustomBoundsForThrobber(const gfx::Size& throbber,
+                                             gfx::Rect* bounds) const {
+  gfx::Point origin(throbber_right_- throbber.width(),
+                   throbber_center_y_ - throbber.height() / 2);

[whywhat, 2010/12/09 16:20:18]

Move this one space to the right.
Also as I noted in ctor, if we happen to reach this point before layout is
calculated, we're in trouble.

[altimofeev, 2010/12/10 16:37:40]

Added call to Layout() if there wasn't any.

+  bounds->set_origin(origin);
+  bounds->set_size(throbber);
+  return true;
 }
 
 gfx::Rect NewUserView::GetPasswordBounds() const {
   return password_field_->GetScreenBounds();
 }
 
 gfx::Rect NewUserView::GetUsernameBounds() const {
   return username_field_->GetScreenBounds();
 }
 
-void NewUserView::StartThrobber() {
-  throbber_->Start();
-}
-
-void NewUserView::StopThrobber() {
-  throbber_->Stop();
-}
-
 bool NewUserView::HandleKeystroke(views::Textfield* s,
     const views::Textfield::Keystroke& keystroke) {
   if (!CrosLibrary::Get()->EnsureLoaded() || login_in_process_)
     return false;
 
   if (keystroke.GetKeyboardCode() == app::VKEY_RETURN) {
     Login();
     // Return true so that processing ends
     return true;
   } else if (keystroke.GetKeyboardCode() == app::VKEY_LEFT) {
@@ skipping 18 matching lines @@
   languages_menubutton_->SetEnabled(enabled);
   username_field_->SetEnabled(enabled);
   password_field_->SetEnabled(enabled);
   sign_in_button_->SetEnabled(enabled);
   if (need_create_account_) {
     create_account_link_->SetEnabled(enabled);
   }
   if (need_guest_link_) {
     guest_link_->SetEnabled(enabled);
   }
-  delegate_->SetStatusAreaEnabled(enabled);
 }
 
 void NewUserView::InitLink(views::Link** link) {
   *link = new views::Link(std::wstring());
   (*link)->SetController(this);
   (*link)->SetNormalColor(login::kLinkColor);
   (*link)->SetHighlightedColor(login::kLinkColor);
   AddChildView(*link);
 }
 
 }  // namespace chromeos