Place the spinner in the right corner of the controls window.

chrome/browser/chromeos/login/helper.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/helper.h"
 
 #include "app/resource_bundle.h"
 #include "chrome/browser/google/google_util.h"
 #include "gfx/canvas_skia.h"
 #include "googleurl/src/gurl.h"
 #include "grit/theme_resources.h"
 #include "third_party/skia/include/effects/SkGradientShader.h"
 #include "views/controls/button/menu_button.h"
 #include "views/controls/button/native_button.h"
 #include "views/controls/label.h"
 #include "views/controls/textfield/textfield.h"
 #include "views/controls/throbber.h"
 #include "views/painter.h"
 #include "views/screen.h"
+#include "views/widget/widget.h"
 
 namespace chromeos {
 
 namespace {
 
 // Time in ms per throbber frame.
 const int kThrobberFrameMs = 60;
 
 // Time in ms before smoothed throbber is shown.
 const int kThrobberStartDelayMs = 500;
@@ skipping 30 matching lines @@
     s->unref();
     canvas->AsCanvasSkia()->drawRect(rect, paint);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BackgroundPainter);
 };
 
 }  // namespace
 
+ThrobberManager::ThrobberManager() : throbber_widget_(NULL) {
+}
+
+ThrobberManager::~ThrobberManager() {
+  Stop();
+}
+
+void ThrobberManager::StartShow(views::Widget* host,
+                                views::Throbber* throbber,
+                                int right_shift) {
+  if (throbber_widget_) {
+    delete throbber;
+    return;

[whywhat, 2010/12/09 16:20:18]

Shouldn't this be a check? Also, why delete throbber? Do we own it since it was
passed to us?
Or maybe we don't need to return but to create a new throbber widget?

[altimofeev, 2010/12/10 16:37:40]

Changed the behavior. Now, previously created throbber is closed (if any) and
new one is opened. 

+  }
+
+  gfx::Rect host_bounds;
+  host->GetBounds(&host_bounds, false);
+  gfx::Rect bounds(throbber->GetPreferredSize());
+  bounds.set_x(host_bounds.width() - right_shift - bounds.width());
+  bounds.set_y((host_bounds.height() - bounds.height()) / 2);
+  StartShow(host, throbber, bounds);
+}
+
+void ThrobberManager::StartShow(views::Widget* host,
+                                views::Throbber* throbber,
+                                const gfx::Rect relative_bounds) {
+  if (throbber_widget_) {
+    delete throbber;
+    return;
+  }
+
+  throbber_widget_ =
+      views::Widget::CreatePopupWidget(views::Widget::Transparent,
+                                       views::Widget::NotAcceptEvents,
+                                       views::Widget::DeleteOnDestroy,
+                                       views::Widget::DontMirrorOriginInRTL);
+  gfx::Rect host_bounds;
+  host->GetBounds(&host_bounds, false);
+  gfx::Rect bounds = relative_bounds;
+  bounds.Offset(host_bounds.origin());
+  throbber_widget_->InitWithWidget(host, bounds);
+  throbber_widget_->SetContentsView(throbber);
+  throbber_widget_->Show();
+  throbber->Start();
+}
+
+void ThrobberManager::Stop() {
+  if (throbber_widget_) {
+    throbber_widget_->Close();

[whywhat, 2010/12/09 16:20:18]

So we delete it in Start, but Close in Stop? Why the difference?

[altimofeev, 2010/12/10 16:37:40]

In Start we have been deleting |throbber| which was an unused view.

+    throbber_widget_ = NULL;
+  }
+}
+
 views::Throbber* CreateDefaultSmoothedThrobber() {
   views::SmoothedThrobber* throbber =
       new views::SmoothedThrobber(kThrobberFrameMs);
   throbber->SetFrames(
       ResourceBundle::GetSharedInstance().GetBitmapNamed(IDR_SPINNER));
   throbber->set_start_delay_ms(kThrobberStartDelayMs);
   return throbber;
 }
 
 views::Throbber* CreateDefaultThrobber() {
@@ skipping 51 matching lines @@
   gfx::Size preferred_size = NativeButton::GetPreferredSize();
   // Set minimal width.
   if (preferred_size.width() < kButtonMinWidth)
     preferred_size.set_width(kButtonMinWidth);
   return preferred_size;
 }
 
 }  // namespace login
 
 }  // namespace chromeos
-