Place the spinner in the right corner of the controls window.

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <algorithm>
 #include <functional>
 #include <map>
 
@@ skipping 196 matching lines @@
   background_view_ = background_view;
 }
 
 void ExistingUserController::LoginNewUser(const std::string& username,
                                           const std::string& password) {
   SelectNewUser();
   UserController* new_user = controllers_.back();
   DCHECK(new_user->is_new_user());
   if (!new_user->is_new_user())
     return;
-  NewUserView* new_user_view = new_user->new_user_view();
-  new_user_view->SetUsername(username);

[whywhat, 2010/12/13 07:57:35]

Note: this was used to auto fill username after account creation though password
was empty (we didn't want to store it in memory to pass between screens). I
guess it's okay for now to break this and fix when we'll implement account
creation.

[altimofeev, 2010/12/13 15:42:45]

Agree.

 
   if (password.empty())
     return;
 
-  new_user_view->SetPassword(password);
-  new_user_view->Login();
+  new_user->OnLogin(username, password);
 }
 
 void ExistingUserController::SelectNewUser() {
   SelectUser(controllers_.size() - 1);
 }
 
 void ExistingUserController::SetStatusAreaEnabled(bool enable) {
   if (background_view_) {
     background_view_->SetStatusAreaEnabled(enable);
   }
@@ skipping 119 matching lines @@
   background_window_ = NULL;
 
   controller->Init(screen_name, background_bounds_);
   controller->set_start_url(start_url_);
   controller->Show();
 
   // And schedule us for deletion. We delay for a second as the window manager
   // is doing an animation with our windows.
   DCHECK(!delete_scheduled_instance_);
   delete_scheduled_instance_ = this;
+
+  // Stop throbbers now to prevent throbbers be visible under the newly created
+  // windows.
+  for (size_t i = 0; i < controllers_.size(); ++i) {
+    controllers_[i]->StopThrobber();
+  }
+
   delete_timer_.Start(base::TimeDelta::FromSeconds(1), this,
                       &ExistingUserController::Delete);
 }
 
 void ExistingUserController::RemoveUser(UserController* source) {
   ClearErrors();
 
   // Owner is not allowed to be removed from the device.
   // It must be enforced at upper levels.
   DCHECK(user_settings_->RequestTrustedOwner(NULL));
@@ skipping 88 matching lines @@
     error_text = l10n_util::GetStringF(
         error_id, l10n_util::GetString(IDS_PRODUCT_OS_NAME));
   } else {
     error_text = l10n_util::GetString(error_id);
   }
   // TODO(dpolukhin): show detailed error info. |details| string contains
   // low level error info that is not localized and even is not user friendly.
   // For now just ignore it because error_text contains all required information
   // for end users, developers can see details string in Chrome logs.
 
-  gfx::Rect bounds = controllers_[selected_view_index_]->GetScreenBounds();
+  gfx::Rect bounds =
+      controllers_[selected_view_index_]->GetMainInputScreenBounds();

[whywhat, 2010/12/13 07:57:35]

Maybe simply call the method GetMessageBubblePosition() if that's what the
result is used for?

[altimofeev, 2010/12/13 15:42:45]

Actually it is used to calculate the bubble position, not the position itself.

   BubbleBorder::ArrowLocation arrow;
   if (controllers_[selected_view_index_]->is_new_user()) {
     arrow = BubbleBorder::LEFT_TOP;
   } else {
     // Point info bubble arrow to cursor position (approximately).
     bounds.set_width(kCursorOffset * 2);
     arrow = BubbleBorder::BOTTOM_LEFT;
   }
   std::wstring help_link;
   if (error_id == IDS_LOGIN_ERROR_AUTHENTICATING_HOSTED) {
@@ skipping 130 matching lines @@
 void ExistingUserController::RecoverEncryptedData(
     const std::string& old_password) {
   login_performer_->RecoverEncryptedData(old_password);
 }
 
 void ExistingUserController::ResyncEncryptedData() {
   login_performer_->ResyncEncryptedData();
 }
 
 }  // namespace chromeos