Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 57083: lcov-1.7 into third_party for code coverage on POSIX systems.... (Closed)

Created:
11 years, 8 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, Mark Larson
Visibility:
Public.

Description

lcov-1.7 into third_party for code coverage on POSIX systems. Non-lcov-1.7 files are lcov/LICENCE lcov/README.chromium lcov/bin/mcov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13066

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18799 lines, -0 lines) Patch
A third_party/lcov/CHANGES View 1 chunk +311 lines, -0 lines 0 comments Download
A third_party/lcov/LICENSE View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/lcov/Makefile View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/lcov/README View 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/lcov/README.chromium View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/lcov/bin/gendesc View 1 chunk +223 lines, -0 lines 0 comments Download
A third_party/lcov/bin/genhtml View 1 chunk +4819 lines, -0 lines 0 comments Download
A third_party/lcov/bin/geninfo View 1 chunk +2178 lines, -0 lines 0 comments Download
A third_party/lcov/bin/genpng View 1 chunk +381 lines, -0 lines 0 comments Download
A third_party/lcov/bin/install.sh View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/lcov/bin/lcov View 1 chunk +2699 lines, -0 lines 0 comments Download
A third_party/lcov/bin/mcov View 1 1 chunk +289 lines, -0 lines 0 comments Download
A third_party/lcov/bin/updateversion.pl View 1 chunk +146 lines, -0 lines 0 comments Download
A third_party/lcov/contrib/galaxy/CHANGES View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/lcov/contrib/galaxy/README View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/lcov/contrib/galaxy/conglomerate_functions.pl View 1 chunk +195 lines, -0 lines 0 comments Download
A third_party/lcov/contrib/galaxy/gen_makefile.sh View 1 chunk +129 lines, -0 lines 0 comments Download
A third_party/lcov/contrib/galaxy/genflat.pl View 1 chunk +1238 lines, -0 lines 0 comments Download
A third_party/lcov/contrib/galaxy/posterize.pl View 1 chunk +312 lines, -0 lines 0 comments Download
A third_party/lcov/descriptions.tests View 1 chunk +2990 lines, -0 lines 0 comments Download
A third_party/lcov/example/Makefile View 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/lcov/example/README View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/lcov/example/descriptions.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/lcov/example/example.c View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/lcov/example/gauss.h View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/lcov/example/iterate.h View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/lcov/example/methods/gauss.c View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/lcov/example/methods/iterate.c View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/lcov/lcovrc View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/lcov/man/gendesc.1 View 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/lcov/man/genhtml.1 View 1 chunk +461 lines, -0 lines 0 comments Download
A third_party/lcov/man/geninfo.1 View 1 chunk +323 lines, -0 lines 0 comments Download
A third_party/lcov/man/genpng.1 View 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/lcov/man/lcov.1 View 1 chunk +557 lines, -0 lines 0 comments Download
A third_party/lcov/man/lcovrc.5 View 1 chunk +557 lines, -0 lines 0 comments Download
A third_party/lcov/rpm/lcov.spec View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Grabowski
11 years, 8 months ago (2009-04-01 01:44:01 UTC) #1
Mark Mentovai
RS LGTM Ignore the question in the other review about checking in lcov, I obviously ...
11 years, 8 months ago (2009-04-01 02:36:52 UTC) #2
John Grabowski
http://codereview.chromium.org/57083/diff/1/9 File third_party/lcov/LICENCE (right): http://codereview.chromium.org/57083/diff/1/9#newcode1 Line 1: Licence copied from bin/lcov: On 2009/04/01 02:36:53, Mark ...
11 years, 8 months ago (2009-04-03 03:25:54 UTC) #3
Mark Mentovai
11 years, 8 months ago (2009-04-03 03:36:28 UTC) #4
Cool.

TVL told me that mcov also changes the format.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698