Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 5708004: Changes to FirstRunBrowserProcess that break chrome frame. (Closed)

Created:
10 years ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Single deinlining in first_run.{cc,h} (This used to break chrome_frame linking, but after rebasing, there doesn't seem to be any issue.) BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69064

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/browser/first_run/first_run.h View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Small, but stampable.
10 years ago (2010-12-13 23:11:02 UTC) #1
James Hawkins
10 years ago (2010-12-13 23:12:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698