Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: build/SConscript.main

Issue 57077: Print out some warnings on unsupported build flags. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.main
diff --git a/build/SConscript.main b/build/SConscript.main
index 2b91fc22aa51aafb1468fdab70a7720d07a90f91..0f6d8334a66f7155c3c9e95b8693d974f3d250c0 100644
--- a/build/SConscript.main
+++ b/build/SConscript.main
@@ -155,7 +155,13 @@ root_env = Environment(
'__env__, RDirs, TARGET, SOURCE)}'),
)
-root_env['req_system_libs'] = ARGUMENTS.get('SYSTEM_LIBS', '').split(',')
+root_env['req_system_libs'] = []
+if 'SYSTEM_LIBS' in ARGUMENTS:
+ root_env['req_system_libs'] = ARGUMENTS['SYSTEM_LIBS'].split(',')
+ print "WARNING: Using system libs is not yet supported and may fail."
+ print "WARNING: You should only use this flag if you're willing to diagnose"
+ print "WARNING: and fix the inevitable link failures."
+
root_env['_GYP'] = ARGUMENTS.get('GYP') and '_gyp' or ''
def WantSystemLib(env, lib):
@@ -589,6 +595,9 @@ if ARGUMENTS.get('SYMBOLS') == '1':
# Build shared libraries (useful for fast links) when SHARED=1.
if ARGUMENTS.get('SHARED') == '1':
+ print "WARNING: The shared link frequently breaks and is unlikely to work."
+ print "WARNING: You should only use this flag if you're willing to diagnose"
+ print "WARNING: and fix the inevitable link failures."
linux_env.Replace(COMPONENT_STATIC=False)
# Build with system-provided NSS and GTK.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698